Uh oh!
There was an error while loading. Please reload this page.
test: remove obsolete lint config comments - #12868
Closed
Trott wants to merge 1 commit into
Closed
Conversation
The `max-len` ESLint rule is configured to be forgiving for lines that contain a regular expression literal. Remove disabling comments that are no longer required in test-repl.js
lpinca
approved these changes
May 6, 2017
vsemozhetbyt
approved these changes
May 6, 2017
gibfahn
approved these changes
May 6, 2017
refack
approved these changes
May 6, 2017
refack
commented
May 6, 2017
Contributor
DavidCai1111
approved these changes
May 6, 2017
benjamingr
approved these changes
May 6, 2017
silverwind
approved these changes
May 6, 2017
jasnell
approved these changes
May 7, 2017
cjihrig
approved these changes
May 8, 2017
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 10, 2017
The `max-len` ESLint rule is configured to be forgiving for lines that contain a regular expression literal. Remove disabling comments that are no longer required in test-repl.js PR-URL: nodejs#12868 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott
commented
May 10, 2017
MemberAuthor
Landed in 57a08e2 |
anchnk pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
The `max-len` ESLint rule is configured to be forgiving for lines that contain a regular expression literal. Remove disabling comments that are no longer required in test-repl.js PR-URL: nodejs#12868 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
gibfahn
commented
Jun 20, 2017
Member
Feel free to backport if you'd like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
max-lenESLint rule is configured to be forgiving for lines thatcontain a regular expression literal. Remove disabling comments that are
no longer required in test-repl.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test