Skip to content

test: update test for url.parse() to match the exact error through re…#12879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreicioromila wants to merge 3 commits into from
Closed

test: update test for url.parse() to match the exact error through re… #12879

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
411cf56
test: update test for url.parse() to match the exact error through re…
andreicioromila May 7, 2017
5b86bd5
test: allign the function and regexp vertically to keep lines short
andreicioromila May 7, 2017
ef07ba4
test: add function and symbol validation for url.parse()
andreicioromila May 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions test/parallel/test-url-parse-invalid-input.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,13 @@ const url = require('url');
0.0,
0,
[],
{}
].forEach(function(val) {
assert.throws(function() { url.parse(val); }, TypeError);
{},
() => {},
Symbol('foo')
].forEach((val) => {
assert.throws(() => { url.parse(val); },
/^TypeError: Parameter "url" must be a string, not (undefined|boolean|number|object|function|symbol)$/);
});

assert.throws(function() { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/);
assert.throws(() => { url.parse('http://%E0%A4%A@fail'); },

@jasnelljasnellMay 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nit: the { and } around the body of the arrow function here can be omitted but isn't necessary.

@TrottTrottMay 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say the braces should not be omitted. That would change it from merely running url.parse() to returning a value. If it was { return url.parse(...); } then omitting the braces (and the return) would make sense. It's mostly a semantic difference, but I think it's important.

/^URIError: URI malformed$/);