Uh oh!
There was an error while loading. Please reload this page.
src: fix comments re PER_ISOLATE macros - #12899
Conversation
There was a problem hiding this comment.
V is (almost?) always another macro, not a C function. :) (You can change s/invoked/expanded for that in the last sentence, if you don’t have a better word in mind.)
There was a problem hiding this comment.
I guess it could technically be anything which could syntactically be followed by a parameter list? I'll rephrase.
There was a problem hiding this comment.
I know it’s copy-pasted, but “crazy” isn’t really an appropriate word here… not sure how to phrase it better, but if nothing else comes to your mind, you can go with something like “dark magic”. ;)
There was a problem hiding this comment.
wild is my personal substitution.
There was a problem hiding this comment.
I took out that sentence entirely and it doesn't seem we lose anything, see what you think.
PR-URL: nodejs#12899 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
joshgav
commented
May 10, 2017
Landed in dd6e3f6. Thanks! |
PR-URL: nodejs#12899 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
gibfahn
commented
Jun 20, 2017
Marking dont-land as it conflicts. Feel free to backport if you'd like to. |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesUpdate and clarify the comments on the PER_ISOLATE macros in
envand move to right before the macros they describe.