Uh oh!
There was an error while loading. Please reload this page.
doc: Update doc of publicEncrypt method - #12947
Closed
fhalde wants to merge 1 commit into
Closed
Conversation
danbev
approved these changes
May 10, 2017
danbev
left a comment
Contributor
There was a problem hiding this comment.
Nit: could you limit the line length to 80 characters so that is consistent?
fhalde
commented
May 10, 2017
ContributorAuthor
Yupp |
mscdex
reviewed
May 10, 2017
mscdex
commented
May 10, 2017
Contributor
While you're in there, would you mind changing |
As per nodejs#12946 the crypto doc for publicEncrypt doesn't tell you whether the encryption happens in place or not.
fhalde
commented
May 10, 2017
ContributorAuthor
done & done @mscdex |
lpinca
approved these changes
May 10, 2017
mscdex
commented
May 10, 2017
Contributor
LGTM |
jasnell
approved these changes
May 10, 2017
gibfahn
approved these changes
May 12, 2017
addaleax
commented
May 19, 2017
Member
Landed in eff9252 |
addaleax pushed a commit
that referenced
this pull request
May 19, 2017
As per #12946 the crypto doc for publicEncrypt doesn't tell you whether the encryption happens in place or not. Fixes: #12946 PR-URL: #12947 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
anchnk pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
As per nodejs#12946 the crypto doc for publicEncrypt doesn't tell you whether the encryption happens in place or not. Fixes: nodejs#12946 PR-URL: nodejs#12947 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
3 tasks
MylesBorins
commented
Jul 17, 2017
Contributor
v6.x? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #12946
the crypto doc for
publicEncryptdoesn't tellyou whether the encryption happens in place or not.
Checklist
Affected core subsystem(s)
doc