Skip to content

doc,build: update configure help messages - #12978

Closed
gibfahn wants to merge 1 commit into
nodejs:masterfrom
gibfahn:config-help
Closed

doc,build: update configure help messages#12978
gibfahn wants to merge 1 commit into
nodejs:masterfrom
gibfahn:config-help

Conversation

@gibfahn

Copy link
Copy Markdown
Member
  • The V8 inspector is no longer experimental.
  • Note that building without SSL disables other features.

Refs: #12768 (comment)

Checklist
Affected core subsystem(s)

doc, build

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label May 11, 2017
@gibfahn

Copy link
Copy Markdown
MemberAuthor

cc/ @refack@sam-github

@refack

Copy link
Copy Markdown
Contributor

I still want --without-ssl to scream, but this is definitely a good start 👍
Ohh, if you're there --without-intl also disables inspector

@refackrefack added the tools Issues and PRs related to the tools directory. label May 11, 2017
Comment threadconfigure Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comma after inspector

- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.
PR-URL: nodejs#12978
Refs: nodejs#12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn

Copy link
Copy Markdown
MemberAuthor

refack pushed a commit to refack/node that referenced this pull request May 26, 2017
- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.
PR-URL: nodejs#12978
Refs: nodejs#12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@refack

Copy link
Copy Markdown
Contributor

Landed in e5e581c

@refackrefack closed this May 26, 2017
@gibfahn
gibfahn deleted the config-help branch May 26, 2017 18:30
jasnell pushed a commit that referenced this pull request May 28, 2017
- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.
PR-URL: #12978
Refs: #12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnelljasnell mentioned this pull request May 28, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.
PR-URL: #12978
Refs: #12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@gibfahn@refack@jasnell@thefourtheye@Trott@lpinca@cjihrig@richardlau@MylesBorins@nodejs-github-bot