build: clean up napi build in test-addons-clean

[joyeecheung]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Refs: #13031

Affected core subsystem(s)

build

[gibfahn]

cc/ @nodejs/n-api @nodejs/build

[refack]

So you're exempt from dealing with vcbuild.bat because apparently we (Windows people) don't get any clean logic at all 😢
That brings up the question? way do you have cleaning targets in Makefile? git clean does a very good job?

[refack]

Approving no need for changes in vcbuild.bat

[joyeecheung]

@refackgit clean doesn't clean up files that are gitignored though (like /test/addons/??_*/)..

I agree there can be similar rules in vcbuild.bat, but that can be solved in another PR, no?

[refack]

@refack git clean doesn't clean up files that are gitignored though (like /test/addons/??_*/)..

-x cleans ignored files (which is good enough for me).

I agree there can be similar rules in vcbuild.bat, but that can be solved in another PR, no?

IMHO there's no need... (If there was any logic IMHO is should have been changed here...)

[mhdawson]

LGTM

[gibfahn]

That brings up the question? way do you have cleaning targets in Makefile? git clean does a very good job?

Interesting question, not sure if there's any difference between the two, except that if you've added some new files and not committed yet, make clean won't delete them but git clean -fdx will (I think).

The subtargets like clean-addons are useful though, you can wipe out the addons build files without having to rebuild node entirely.

[mhdawson]

CI run: https://ci.nodejs.org/job/node-test-pull-request/8099/

[refack]

Interesting question, not sure if there's any difference between the two, except that if you've added some new files and not committed yet, make clean won't delete them but git clean -fdx will (I think).

The subtargets like clean-addons are useful though, you can wipe out the addons build files without having to rebuild node entirely.

Well then you enjoy your well-thought-of Makefile targets 😞

[joyeecheung]

@refack Hmm..I didn't realize that git clean -x does the job as well, sorry. Although I still think this is useful when working on addon tests.

[mhdawson]

I tend to agree that since there is a clean target for regular addons, bringing napi in line with that makes sense. If we decide that there is a better approach then a PR could address that for both the original addons and napi-addons.

Any objections to landing based on that approach ?

[refack]

I was always +1, and as I said no need to add to vcbuild.bat

[mhdawson]

Landed as 6342988