test: refactor test-dns-regress-6244.js

[Trott]

• Move from parallel to internet because it performs a DNS query
• Provide link to relevant issue in comments
• Remove unnecessary explicit no-op function

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test dns

[Trott]

@nodejs/testing

[gibfahn]

My only issue with this would be that the internet tests don't get run very much, so moving to internet basically means ignoring. Of course if there's no feasible way to do this offline then we have no choice.

[Trott]

My only issue with this would be that the internet tests don't get run very much, so moving to internet basically means ignoring.

@gibfahn Discussion to come up with a solution to that at #13061

[addaleax]

Landed in 47e3d00

[MylesBorins]

This test does not pass on v6.x

Please feel free to backport

[Trott]

This test does not pass on v6.x

@MylesBorins Are you sure? That's strange because this moves the test from parallel to internet which means make test and make test-ci now no longer run the test. The only thing this would need to pass is linting.

[gibfahn]

@Trott when backporting we normally run any tests that were changed, not just the ones that make test tests.

This fails as follows:

➜ nodegit:(v6.x-staging)✗❯tools/test.pytest/internet/test-dns-regress-6244.js~/wrk/com/DANGER/node===releasetest-dns-regress-6244===Path: internet/test-dns-regress-6244/Users/gib/wrk/com/DANGER/node/test/common/index.js:431
name: fn.name||'<anonymous>'^TypeError: Cannotreadproperty'name'ofundefinedatObject.exports.mustCall(/Users/gib/wrk/com/DANGER/node/test/common/index.js:431:13)atObject.<anonymous>(/Users/gib/wrk/com/DANGER/node/test/internet/test-dns-regress-6244.js:6:34)atModule._compile(module.js:570:32)atObject.Module._extensions..js(module.js:579:10)atModule.load(module.js:487:32)attryModuleLoad(module.js:446:12)atFunction.Module._load(module.js:438:3)atModule.runMain(module.js:604:10)atrun(bootstrap_node.js:389:7)atstartup(bootstrap_node.js:149:9)
Command: out/Release/node/Users/gib/wrk/com/DANGER/node/test/internet/test-dns-regress-6244.js[00:00|%100|+0|-1]: Done

Given that the only code change in the pr is common.mustCall( () => {} ) -> common.mustCall(), I'm thinking v6.x must be missing the PR to allow mustCall to take no parameters.