Uh oh!
There was an error while loading. Please reload this page.
src: remove unused parameter - #13085
Merged
Merged
Conversation
addaleax
approved these changes
May 17, 2017
cjihrig
approved these changes
May 17, 2017
ronkorving
approved these changes
May 18, 2017
jasnell
approved these changes
May 18, 2017
mscdexforce-pushed
the
src-remove-unused-param
branch
from
May 18, 2017 03:20
a596665 to
c54fbd1Comparemscdex
commented
May 18, 2017
ContributorAuthor
I've removed some more unused parameters and fixed a code typo (although for some reason it didn't seem to make any difference :-S) |
danbev
approved these changes
May 18, 2017
addaleax
approved these changes
May 18, 2017
mscdex
commented
May 18, 2017
ContributorAuthor
I'm marking this as semver-major as it probably should be? If not, feel free to remove the label. |
addaleax
commented
May 18, 2017
Member
@mscdex I don’t think you’re touching anything not guarded by |
mscdex
commented
May 18, 2017
ContributorAuthor
@addaleax Ah you're probably right about that. Thanks. |
PR-URL: nodejs#13085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
PR-URL: nodejs#13085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
mscdexforce-pushed
the
src-remove-unused-param
branch
from
May 22, 2017 20:09
c54fbd1 to
dcc59f9Comparejasnell pushed a commit
that referenced
this pull request
May 23, 2017
PR-URL: #13085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit
that referenced
this pull request
May 23, 2017
PR-URL: #13085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit
that referenced
this pull request
May 23, 2017
PR-URL: #13085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit
that referenced
this pull request
May 23, 2017
PR-URL: #13085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
3 tasks
MylesBorins
commented
Jul 17, 2017
Contributor
Should this be backported to v6.x? |
MylesBorins
commented
Aug 14, 2017
Contributor
ping @mscdex |
mscdex
commented
Aug 14, 2017
ContributorAuthor
I don't know, but I won't have time to backport anytime soon. |
MylesBorins
commented
Sep 19, 2017
Contributor
setting as don't land we can revisit later if we find there are issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/8140/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)