Skip to content

doc: link to common docs in test writing guide - #13118

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:doc-link-to-common-docs
Closed

doc: link to common docs in test writing guide#13118
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:doc-link-to-common-docs

Conversation

@addaleax

Copy link
Copy Markdown
Member
Checklist
Affected core subsystem(s)

doc/guides

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 19, 2017

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refackrefack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to do that 😄

@mscdexmscdex added the test Issues and PRs related to the tests. label May 19, 2017

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

Copy link
Copy Markdown
Member

@addaleax

Copy link
Copy Markdown
MemberAuthor

Landed in 02bf16e

@addaleax
addaleax deleted the doc-link-to-common-docs branch May 23, 2017 18:54
addaleax added a commit that referenced this pull request May 23, 2017
PR-URL: #13118
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request May 24, 2017
PR-URL: #13118
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
PR-URL: #13118
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnelljasnell mentioned this pull request May 28, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@addaleax@mhdawson@refack@Trott@lpinca@cjihrig@gibfahn@mscdex@MylesBorins@nodejs-github-bot