Uh oh!
There was an error while loading. Please reload this page.
test: cover util.format() format placeholders - #13159
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
This commit adds coverage for several edge cases related to util.format() format string placeholders.
refack
approved these changes
May 22, 2017
evanlucas
approved these changes
May 22, 2017
watilde
approved these changes
May 22, 2017
jasnell
approved these changes
May 23, 2017
lpinca
approved these changes
May 23, 2017
addaleax
approved these changes
May 25, 2017
addaleax
commented
May 25, 2017
Member
Landed in 0903dcf |
addaleax pushed a commit
that referenced
this pull request
May 25, 2017
This commit adds coverage for several edge cases related to util.format() format string placeholders. PR-URL: #13159 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell pushed a commit
that referenced
this pull request
May 25, 2017
This commit adds coverage for several edge cases related to util.format() format string placeholders. PR-URL: #13159 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell pushed a commit
that referenced
this pull request
May 28, 2017
This commit adds coverage for several edge cases related to util.format() format string placeholders. PR-URL: #13159 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
MylesBorins
commented
Jul 17, 2017
Contributor
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds coverage for several edge cases related to
util.format()format string placeholders.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test