Uh oh!
There was an error while loading. Please reload this page.
doc: fix code example in inspector.md - #13182
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
vsemozhetbyt
commented
May 24, 2017
ContributorAuthor
refack
approved these changes
May 24, 2017
refack
left a comment
Contributor
There was a problem hiding this comment.
Do we lint for space inside object literals? { a }
vsemozhetbyt
commented
May 24, 2017
ContributorAuthor
@refack No, but this is rather common in the docs. |
jasnell
approved these changes
May 24, 2017
refack
commented
May 24, 2017
Contributor
I personally like it. If it's common we should lint for it. |
vsemozhetbyt
commented
May 24, 2017
ContributorAuthor
Well, if there is some unanimity for this, I could address this. But I would not bother everybody with this PR for spaces only, I've just fixed the |
cjihrig
approved these changes
May 24, 2017
vsemozhetbyt
commented
May 26, 2017
ContributorAuthor
Landed in 329b6e9 |
vsemozhetbyt added a commit
that referenced
this pull request
May 26, 2017
PR-URL: #13182 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit
that referenced
this pull request
May 28, 2017
PR-URL: #13182 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, inspector
console.log(result.value)outputs just4.