Uh oh!
There was an error while loading. Please reload this page.
doc: make socket IPC examples more robust - #13196
Merged
Merged
Conversation
santigimeno
approved these changes
May 24, 2017
Member
There was a problem hiding this comment.
Maybe a note why using pauseOnConnect: true is a good practice.
refack
approved these changes
May 24, 2017
lpinca
reviewed
May 24, 2017
3 tasks
addaleax
commented
Jun 9, 2017
Member
@cjihrig This would need a rebase :) |
cjihrig
commented
Jun 22, 2017
ContributorAuthor
Rebased and addressed comments. |
refack
approved these changes
Jun 22, 2017
This commit aims to improve the documentation examples that send sockets over IPC channels. Specifically, pauseOnConnect is added to a server that inspects the socket before sending and a 'message' handler adds a check that the socket still exists. PR-URL: nodejs#13196 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
addaleax pushed a commit
that referenced
this pull request
Jun 24, 2017
This commit aims to improve the documentation examples that send sockets over IPC channels. Specifically, pauseOnConnect is added to a server that inspects the socket before sending and a 'message' handler adds a check that the socket still exists. PR-URL: #13196 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
commented
Jul 17, 2017
Contributor
Is this applicable to v6.x? |
MylesBorins
commented
Aug 14, 2017
Contributor
ping @cjihrig |
cjihrig
commented
Aug 15, 2017
ContributorAuthor
Yes, I'd say it's applicable. |
MylesBorins
commented
Sep 19, 2017
Contributor
@cjihrig do you have time to backport? |
4 tasks
cjihrig
commented
Sep 20, 2017
ContributorAuthor
Backport in #15482 |
MylesBorins pushed a commit
that referenced
this pull request
Oct 16, 2017
This commit aims to improve the documentation examples that send sockets over IPC channels. Specifically, pauseOnConnect is added to a server that inspects the socket before sending and a 'message' handler adds a check that the socket still exists. PR-URL: #13196 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Oct 25, 2017
This commit aims to improve the documentation examples that send sockets over IPC channels. Specifically, pauseOnConnect is added to a server that inspects the socket before sending and a 'message' handler adds a check that the socket still exists. PR-URL: #13196 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
abhishekumar-tyagi pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
This commit aims to improve the documentation examples that send sockets over IPC channels. Specifically, pauseOnConnect is added to a server that inspects the socket before sending and a 'message' handler adds a check that the socket still exists. PR-URL: nodejs/node#13196 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit aims to improve the documentation examples that send sockets over IPC channels. Specifically,
pauseOnConnectis added to a server that inspects the socket before sending and a'message'handler adds a check that the socket still exists.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc
R= @santigimeno