Skip to content

doc: relocate CII badge - #13283

Closed
refack wants to merge 2 commits into
nodejs:masterfrom
refack:relocate-cii
Closed

doc: relocate CII badge#13283
refack wants to merge 2 commits into
nodejs:masterfrom
refack:relocate-cii

Conversation

@refack

Copy link
Copy Markdown
Contributor

Follow up to #13231 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 29, 2017
@refack

refack commented May 29, 2017

Copy link
Copy Markdown
ContributorAuthor

@refackrefack mentioned this pull request May 29, 2017
2 tasks
@cjihrig

Copy link
Copy Markdown
Contributor

I don't think you want to move the Node logo to the bottom of the README

@Fishrock123

Copy link
Copy Markdown
Contributor

Can you leave the logo up top?

@refack

Copy link
Copy Markdown
ContributorAuthor

Sorry about the logo, already pushed fix.

@Fishrock123

Copy link
Copy Markdown
Contributor

Also, isn't this down a bit far? What about just under the first paragraph-ish?

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but to be honest, I think it looks a little out of place and might be better off removed.

@refack

Copy link
Copy Markdown
ContributorAuthor

Also, isn't this down a bit far? What about just under the first paragraph-ish?

IMHO it works perfectly as a footnote (but I'm admittedly design-blind). Let's see what others think.

@refackrefack self-assigned this May 29, 2017
@gibfahn

gibfahn commented May 29, 2017

Copy link
Copy Markdown
Member

Looks fine there to me. From #6819 it sounds like it was some work to get it, so we might as well keep it.

@lpinca

Copy link
Copy Markdown
Member

We are essentially hiding it which doesn't makes sense imo. I think the scope of a badge is to be visible.

@refack
refackforce-pushed the relocate-cii branch 2 times, most recently from f28d611 to abdbfffCompareMay 29, 2017 22:25
@refack

Copy link
Copy Markdown
ContributorAuthor

Also, isn't this down a bit far? What about just under the first paragraph-ish?

We are essentially hiding it which doesn't makes sense imo. I think the scope of a badge is to be visible.

Commit No. 2 puts it in the bottom of the "preamble"

You can compare the two commits
No. 1
No. 2

@lpinca

Copy link
Copy Markdown
Member

It still seems misplaced to me but definitely better than before.

@gibfahn

Copy link
Copy Markdown
Member

It still seems misplaced to me but definitely better than before.

Where do you think it should be?

@refack

Copy link
Copy Markdown
ContributorAuthor

I tried to put it inline in the preamble; something like:


This project follows the best parctises of the CII image


But as you can see, as usual images don't go well inline :(

@lpinca

Copy link
Copy Markdown
Member

@gibfahn I think below the logo, where it is now, is the best place maybe left aligned instead of centered.

@gibfahn

Copy link
Copy Markdown
Member

@gibfahn I think below the logo, where it is now, is the best place maybe left aligned instead of centered.

Fair enough, maybe we should just leave it where it is then

@refack

Copy link
Copy Markdown
ContributorAuthor

Consensus seems to be to stay as it

@refackrefack closed this Jul 9, 2017
@gibfahngibfahn mentioned this pull request Feb 21, 2018
3 tasks
@refackrefack removed their assignment Oct 20, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@refack@cjihrig@Fishrock123@gibfahn@lpinca@jasnell@nodejs-github-bot