Uh oh!
There was an error while loading. Please reload this page.
doc: relocate CII badge - #13283
Conversation
|
cjihrig
commented
May 29, 2017
I don't think you want to move the Node logo to the bottom of the README |
Fishrock123
commented
May 29, 2017
Can you leave the logo up top? |
refack
commented
May 29, 2017
Sorry about the logo, already pushed fix. |
Fishrock123
commented
May 29, 2017
Also, isn't this down a bit far? What about just under the first paragraph-ish? |
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but to be honest, I think it looks a little out of place and might be better off removed.
refack
commented
May 29, 2017
IMHO it works perfectly as a footnote (but I'm admittedly design-blind). Let's see what others think. |
Looks fine there to me. From #6819 it sounds like it was some work to get it, so we might as well keep it. |
lpinca
commented
May 29, 2017
We are essentially hiding it which doesn't makes sense imo. I think the scope of a badge is to be visible. |
f28d611 to
abdbfffComparerefack
commented
May 29, 2017
lpinca
commented
May 30, 2017
It still seems misplaced to me but definitely better than before. |
gibfahn
commented
May 30, 2017
Where do you think it should be? |
refack
commented
May 30, 2017
lpinca
commented
May 30, 2017
@gibfahn I think below the logo, where it is now, is the best place maybe left aligned instead of centered. |
gibfahn
commented
May 30, 2017
Fair enough, maybe we should just leave it where it is then |
refack
commented
Jul 9, 2017
Consensus seems to be to stay as it |

Follow up to #13231 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc