Uh oh!
There was an error while loading. Please reload this page.
[async_wrap] call destroy hooks on uv_timer_t - #13369
Merged
Merged
Conversation
trevnorrisforce-pushed
the
destroy-on-uv_timer
branch
from
June 1, 2017 12:29
93436c1 to
87ae33bCompareaddaleax
approved these changes
Jun 1, 2017
Member
There was a problem hiding this comment.
Just fyi, the test from #13353 might be better because it uses AsyncResource to trigger the destroy call, so it doesn’t rely on .close() specifics.
ContributorAuthor
There was a problem hiding this comment.
Ah thanks. And I can remove the setTimeout() at the bottom of the test.
Member
There was a problem hiding this comment.
will this not call the destroy hook synchronously if emitDestroy was called from within the destroy hook? We don't want that because destroy hooks should never be called synchronously.
ContributorAuthor
There was a problem hiding this comment.
@AndreasMadsen It would act like a nextTick(). The current execution scope would complete before the destroy hook was called.
Member
There was a problem hiding this comment.
Yeah, that came to me a few hours after I wrote that. Thanks!
trevnorrisforce-pushed
the
destroy-on-uv_timer
branch
from
June 1, 2017 20:41
87ae33b to
fe1e23eComparetrevnorris
commented
Jun 1, 2017
ContributorAuthor
@addaleax Thanks for pointing to the other test. Also forgot to include your test for |
3 tasks
AndreasMadsen
approved these changes
Jun 1, 2017
AndreasMadsen
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for taking care of this.
jasnell
approved these changes
Jun 1, 2017
4 tasks
3 tasks
trevnorrisforce-pushed
the
destroy-on-uv_timer
branch
from
June 2, 2017 22:09
fe1e23e to
a127045Comparetrevnorrisforce-pushed
the
destroy-on-uv_timer
branch
from
June 2, 2017 22:10
a127045 to
5e4aaeeCompareCalling the destroy callbacks in a uv_idle_t causes a timing issue where
if a handle or request is closed then the class isn't deleted until
uv_close() callbacks are called (which happens after the poll phase).
This results in some destroy callbacks not being called just before the
application exits. So instead switch the destroy callbacks to be called
in a uv_timer_t with the timeout set to zero.
When uv_run() is called with UV_RUN_ONCE the final operation of the
event loop is to process all remaining timers. By setting the timeout to
zero it results in the destroy callbacks being processed after
uv_close() but before uv_run() returned. Processing the destroyed ids
that were previously missed.
Also, process the destroy_ids_list() in a do {} while() loop that makes
sure the vector is empty before returning. Which also makes running
clear() unnecessary.
Fixes: nodejs#13262
PR-URL: nodejs#13369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>Verify that the destroy callback for a TCP server is called before exit if it is closed in another destroy callback. Fixes: nodejs#13262 PR-URL: nodejs#13369 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
trevnorrisforce-pushed
the
destroy-on-uv_timer
branch
from
June 2, 2017 22:22
5e4aaee to
78b1358Comparetrevnorris
commented
Jun 2, 2017
ContributorAuthor
jasnell pushed a commit
that referenced
this pull request
Jun 5, 2017
Calling the destroy callbacks in a uv_idle_t causes a timing issue where
if a handle or request is closed then the class isn't deleted until
uv_close() callbacks are called (which happens after the poll phase).
This results in some destroy callbacks not being called just before the
application exits. So instead switch the destroy callbacks to be called
in a uv_timer_t with the timeout set to zero.
When uv_run() is called with UV_RUN_ONCE the final operation of the
event loop is to process all remaining timers. By setting the timeout to
zero it results in the destroy callbacks being processed after
uv_close() but before uv_run() returned. Processing the destroyed ids
that were previously missed.
Also, process the destroy_ids_list() in a do {} while() loop that makes
sure the vector is empty before returning. Which also makes running
clear() unnecessary.
Fixes: #13262
PR-URL: #13369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_wrap
Summary
Calling the destroy callbacks in a
uv_idle_tcauses a timing issue whereif a handle or request is closed then the class isn't deleted until
uv_close()callbacks are called (which happens after the poll phase).This results in some destroy callbacks not being called just before the
application exits. So instead switch the destroy callbacks to be called
in a
uv_timer_twith the timeout set to zero.When
uv_run()is called withUV_RUN_ONCEthe final operation of theevent loop is to process all remaining timers. By setting the timeout to
zero it results in the destroy callbacks being processed after
uv_close()but beforeuv_run()returned. Processing the destroyed idsthat were previously missed.
Also, process the
destroy_ids_list()in ado {} while()loop that makessure the vector is empty before returning. Which also makes running
clear()unnecessary.Fixes: #13262
@addaleax Hope you don't mind that I added the relevant test you included in #13286 (left you as the committer, but altered the commit message)
CI: https://ci.nodejs.org/job/node-test-commit/10272/