Uh oh!
There was an error while loading. Please reload this page.
Support for building io.js as a static library - #1341
Closed
hoho wants to merge 2 commits into
Closed
Conversation
One static library could not be bundled into another, that's why it's necessary to skip `-force_load` and `--whole-archive` linker options to build io.js itself as a static library. `node_target_type` variable has been added to node.gyp, along with `--target-static` option in configure script. nodejs#686
Fishrock123
commented
Apr 4, 2015
Contributor
cc @bnoordhuis |
hoho
commented
Apr 4, 2015
ContributorAuthor
I've pull requested a piece of my fixes. If everything goes well, I'd like to extend the testing subsystem with an ability to run all the tests for some binary linked with io.js from a static library (this would also be a documentation of how to link). I also have an issue about |
bnoordhuis
commented
Apr 4, 2015
Member
LGTM but can I suggest you rename the configure switch to |
hoho
commented
Apr 4, 2015
ContributorAuthor
Sure, I was just thinking that |
jbergstroem
commented
Apr 7, 2015
Member
LGTM. Tested on smartos/freebsd this weekend. |
bnoordhuis pushed a commit
that referenced
this pull request
Apr 11, 2015
One static library could not be bundled into another, that's why it's necessary to skip `-force_load` and `--whole-archive` linker options to build io.js itself as a static library. `node_target_type` variable has been added to node.gyp, along with `--enable-static` option in configure script. Fixes: #686 PR-URL: #1341 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
bnoordhuis
commented
Apr 11, 2015
Member
Landed in cd38a4a, thanks. For posterity, I had to fix a merge conflict and undid some of the stylistic changes while I was there. |
zcbenz
commented
Apr 12, 2015
Contributor
Awesome! |
chrisdickinson added a commit
that referenced
this pull request
Apr 17, 2015
Notable Changes: * build: Support for building io.js as a static library (Marat Abdullin) #1341 * deps: upgrade openssl to 1.0.2a (Shigeki Ohtsu) #1389 * npm: Upgrade npm to 2.8.3. (Forrest L Norvell) #1448 * src: allow multiple arguments to be passed to process.nextTick (Trevor Norris) #1077 * module: interaction of require('.') with NODE_PATH has been restored and deprecated. This functionality will be removed at a later point. (Roman Reiss) #1363
chrisdickinson added a commit
that referenced
this pull request
Apr 17, 2015
Notable Changes: * build: Support for building io.js as a static library (Marat Abdullin) #1341 * deps: upgrade openssl to 1.0.2a (Shigeki Ohtsu) #1389 * npm: Upgrade npm to 2.8.3. (Forrest L Norvell) #1448 * src: allow multiple arguments to be passed to process.nextTick (Trevor Norris) #1077 * module: the interaction of require('.') with NODE_PATH has been restored and deprecated. This functionality will be removed at a later point. (Roman Reiss) #1363
chrisdickinson added a commit
that referenced
this pull request
Apr 20, 2015
Notable Changes: * build: revert vcbuild.bat changes * changes inherited from v1.8.0: * build: Support for building io.js as a static library (Marat Abdullin) #1341 * npm: Upgrade npm to 2.8.3. (Forrest L Norvell) #1448 * deps: upgrade openssl to 1.0.2a (Shigeki Ohtsu) #1389 * src: allow multiple arguments to be passed to process.nextTick (Trevor Norris) #1077 * module: the interaction of require('.') with NODE_PATH has been restored and deprecated. This functionality will be removed at a later point. (Roman Reiss) #1363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One static library could not be bundled into another, that's why
it's necessary to skip
-force_loadand--whole-archivelinkeroptions to build io.js itself as a static library.
node_target_typevariable has been added to node.gyp, alongwith
--target-staticoption in configure script.#686 for more information.