Uh oh!
There was an error while loading. Please reload this page.
doc: emphasize Collaborators in GOVERNANCE.md - #13423
Closed
Trott wants to merge 1 commit into
Closed
Conversation
addaleax
approved these changes
Jun 2, 2017
gibfahn
reviewed
Jun 3, 2017
Member
There was a problem hiding this comment.
You can exhaust options, but can you exhaust discussion?
MemberAuthor
There was a problem hiding this comment.
I agree it's at least mildly awkward, but I don't think it's unclear. I'm certainly open to suggestions for better wording. Other options that spring to mind:
This should only be used if discussion among disagreeing Collaborators fails reaches an impasse.
This should only be as a last resort.
This should only be used if there seems to be no other path to resolution.
Member
There was a problem hiding this comment.
How about
This should only be used if disagreements between Collaborators cannot be resolved through discussion.
MemberAuthor
There was a problem hiding this comment.
Thanks, @gibfahn. Changed be used to happen but otherwise went with your suggestion:
This should only happen if disagreements between Collaborators cannot be resolved through discussion.
bnoordhuis
approved these changes
Jun 3, 2017
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
LGTM either way but I like Gibson's suggestion.
lpinca
approved these changes
Jun 4, 2017
thefourtheye
approved these changes
Jun 4, 2017
targos
approved these changes
Jun 6, 2017
evanlucas
approved these changes
Jun 6, 2017
Put information about Collaborators in GOVERNANCE.md before information about the CTC. For most things, the CTC is the last place to go, not the first and Collaborators have a lot of decision-making power in the project. The governance doc should reflect that.
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 6, 2017
Put information about Collaborators in GOVERNANCE.md before information about the CTC. For most things, the CTC is the last place to go, not the first and Collaborators have a lot of decision-making power in the project. The governance doc should reflect that. PR-URL: nodejs#13423 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Trott
commented
Jun 6, 2017
MemberAuthor
Landed in b830c97 |
addaleax pushed a commit
that referenced
this pull request
Jun 10, 2017
Put information about Collaborators in GOVERNANCE.md before information about the CTC. For most things, the CTC is the last place to go, not the first and Collaborators have a lot of decision-making power in the project. The governance doc should reflect that. PR-URL: #13423 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
3 tasks
MylesBorins pushed a commit
that referenced
this pull request
Jul 17, 2017
Put information about Collaborators in GOVERNANCE.md before information about the CTC. For most things, the CTC is the last place to go, not the first and Collaborators have a lot of decision-making power in the project. The governance doc should reflect that. PR-URL: #13423 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put information about Collaborators in GOVERNANCE.md before information
about the CTC. For most things, the CTC is the last place to go, not the
first and Collaborators have a lot of decision-making power in the
project. The governance doc should reflect that.
(There's also one paragraph re-formatted to wrap at 80 chars.)
@nodejs/ctc
Checklist
Affected core subsystem(s)
doc