src: check whether inspector is doing io

[sam-github]

Inspector start means that it exists, but doesn't mean it is listening
on a port, that only happens if it is doing I/O (i.e. has an io object).

Fixes: #13499

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

src,inspector

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/8521/

[refack]

@eugeneo can we have some of these in #13478?

[eugeneo]

I added some tests there

[refack]

why not default arg port = ''

[sam-github]

@refack Thanks for your suggestion, it was a good one.

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/8522/

[bnoordhuis]

DRY: if (auto io = env->inspector_agent()->io()) port = io->port();?

Should it check io->IsStarted()? The inspector has a venerable multitude of IsStarted methods...

[sam-github]

No. IsStarted() should be called IsInitialized(), and it always happens if the Agent was constructed, unless I very much misremember. I'll check again, but I'm pretty sure. And I agree, the word "start" in method names is a bit overused in node's c++ source.

[sam-github]

yes, IsStarted() means its newed a NodeInspectorClient client_, its the io_ that means its listening on a port.

[sam-github]

I changed the C++, so ci again: https://ci.nodejs.org/job/node-test-pull-request/8565/

[sam-github]

OS X failed on

not ok 174 async-hooks/test-callback-error

@addaleax (in the absence of an at-nodejs/async-hooks)

AIX failed on

not ok 13 async-hooks/test-fseventwrap

@gireeshpunathil would you know anything about that?

Neither look related.

[addaleax]

OS X failed on

not ok 174 async-hooks/test-callback-error

@addaleax (in the absence of an at-nodejs/async-hooks)

we do have @nodejs/async_hooks ;) I don’t really know how that test would be flaky.

[gibfahn]

not ok 13 async-hooks/test-fseventwrap

#13577 was just raised, so I believe you're okay there.

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/8578/ to see if the async hooks test always fails

[gibfahn]

not ok 174 async-hooks/test-callback-error

1000 runs on my machine (macOS sierra) with no failures, I think this is good to go.

[AndreasMadsen]

I don’t really know how that test would be flaky.

It is a real mystery. See: #13527

[sam-github]

OK, everything passed this time except for

not ok 1432 inspector/test-inspector-port-zero-cluster # TODO : Fix flaky test

on centos: https://ci.nodejs.org/job/node-test-commit-linux/10482/nodes=centos7-64/

[gibfahn]

not ok 1432 inspector/test-inspector-port-zero-cluster # TODO : Fix flaky test

Should really have fixed that flaky test before landing this @sam-github 😉

[refack]

not ok 174 async-hooks/test-callback-error

I don’t really know how that test would be flaky.

It is a real mystery. See: #13527

It just is 🤷‍♂️ (probably the process.abort taking too long)
#13559