Skip to content

src: correct indentation for X509ToObject - #13543

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:X509ToObject-indentation
Closed

src: correct indentation for X509ToObject#13543
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:X509ToObject-indentation

Conversation

@danbev

Copy link
Copy Markdown
Contributor

The indentation in one of the if statements blocks is four spaces
instead of two. This commit changes the indentation to two spaces.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, crypto

The indentation in one of the if statements blocks is four spaces
instead of two. This commit changes the indentation to two spaces.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jun 8, 2017

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t need to wait 48 hours

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danbev added a commit to danbev/node that referenced this pull request Jun 9, 2017
The indentation in one of the if statements blocks is four spaces
instead of two. This commit changes the indentation to two spaces.
PR-URL: nodejs#13543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in 8f91aa5

@danbevdanbev closed this Jun 9, 2017
addaleax pushed a commit that referenced this pull request Jun 10, 2017
The indentation in one of the if statements blocks is four spaces
instead of two. This commit changes the indentation to two spaces.
PR-URL: #13543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@addaleaxaddaleax mentioned this pull request Jun 10, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
3 tasks
@danbev
danbev deleted the X509ToObject-indentation branch June 28, 2017 05:24
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
The indentation in one of the if statements blocks is four spaces
instead of two. This commit changes the indentation to two spaces.
PR-URL: #13543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@danbev@addaleax@cjihrig@mhdawson@MylesBorins@nodejs-github-bot