Uh oh!
There was an error while loading. Please reload this page.
test: refactor async-hooks test-callback-error - #13554
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Two child processes have their logic in a switch statement and a third uses an `if` statement to detect it. Move all three child process tasks into switch statement.
trevnorris
approved these changes
Jun 8, 2017
trevnorris
left a comment
Contributor
There was a problem hiding this comment.
Looks innocuous. If CI is happy then LGTM.
Trott
commented
Jun 8, 2017
MemberAuthor
3 tasks
refack
approved these changes
Jun 8, 2017
refack
commented
Jun 8, 2017
Contributor
I feel like sisyphus https://ci.nodejs.org/job/node-test-commit-freebsd/9623/nodes=freebsd10-64/ |
DavidCai1111
approved these changes
Jun 9, 2017
cjihrig
approved these changes
Jun 9, 2017
jasnell
approved these changes
Jun 9, 2017
lpinca
approved these changes
Jun 10, 2017
hiroppy
approved these changes
Jun 11, 2017
Trott
commented
Jun 11, 2017
MemberAuthor
Landed in a08b59f |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 11, 2017
Two child processes have their logic in a switch statement and a third uses an `if` statement to detect it. Move all three child process tasks into switch statement. PR-URL: nodejs#13554 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
addaleax pushed a commit
that referenced
this pull request
Jun 12, 2017
Two child processes have their logic in a switch statement and a third uses an `if` statement to detect it. Move all three child process tasks into switch statement. PR-URL: #13554 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two child processes have their logic in a switch statement and a third
uses an
ifstatement to detect it. Move all three child process tasksinto switch statement.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test async_hooks