Uh oh!
There was an error while loading. Please reload this page.
test: use mustNotCall in test-http-eof-on-connect - #13587
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Confirm that callback is not being invoked in test-http-eof-on-connect.js.
cjihrig
approved these changes
Jun 9, 2017
refack
approved these changes
Jun 9, 2017
addaleax
approved these changes
Jun 10, 2017
gibfahn
approved these changes
Jun 10, 2017
lpinca
approved these changes
Jun 10, 2017
Trott
commented
Jun 11, 2017
MemberAuthor
CI is in bad shape right now, but hope springs eternal... |
jasnell
approved these changes
Jun 12, 2017
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 12, 2017
Confirm that callback is not being invoked in test-http-eof-on-connect.js. PR-URL: nodejs#13587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Jun 12, 2017
MemberAuthor
Landed in 77d575d |
addaleax pushed a commit
that referenced
this pull request
Jun 17, 2017
Confirm that callback is not being invoked in test-http-eof-on-connect.js. PR-URL: #13587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
addaleax pushed a commit
that referenced
this pull request
Jun 21, 2017
Confirm that callback is not being invoked in test-http-eof-on-connect.js. PR-URL: #13587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Aug 14, 2017
Confirm that callback is not being invoked in test-http-eof-on-connect.js. PR-URL: #13587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Aug 16, 2017
Confirm that callback is not being invoked in test-http-eof-on-connect.js. PR-URL: #13587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Sep 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirm that callback is not being invoked in
test-http-eof-on-connect.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http