Uh oh!
There was an error while loading. Please reload this page.
child_process: do not extend result for *Sync() - #13601
Merged
Merged
Conversation
cjihrig
commented
Jun 10, 2017
Contributor
I agree that it is unexpected. It looks like this was the behavior going all the way back to at least 0.12.0. The tests referenced in this PR are all newer than that, so I'm not sure that the two things are related. @bnoordhuis or @sam-github do either of you know why the inputs were originally attached to the output? |
refack
approved these changes
Jun 10, 2017
ContributorAuthor
There was a problem hiding this comment.
I don't think it really matters much since we're already explicitly passing 'win32' to this function below here.
mscdexforce-pushed
the
child_process-no-extend-result
branch
from
June 10, 2017 19:44
a19761a to
14f88feComparemscdex
commented
Jun 10, 2017
ContributorAuthor
Forgot to re-add a removed test. New CI: https://ci.nodejs.org/job/node-test-pull-request/8594/ |
refack
approved these changes
Jun 10, 2017
jasnell
approved these changes
Jun 12, 2017
mscdex
commented
Jun 12, 2017
ContributorAuthor
/cc @nodejs/ctc |
mscdexforce-pushed
the
child_process-no-extend-result
branch
from
June 13, 2017 00:45
14f88fe to
1ed6eceComparejasnell
commented
Jun 13, 2017
Member
sam-github
commented
Jun 13, 2017
Contributor
Sorry, I don't know why they were added. Getting rid of them seems like a good idea. |
cjihrig
approved these changes
Jun 13, 2017
refack
commented
Jun 13, 2017
Contributor
CITGM clean |
jasnell
commented
Jun 13, 2017
Member
PR-URL: nodejs#13601 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mscdexforce-pushed
the
child_process-no-extend-result
branch
from
June 13, 2017 23:20
1ed6ece to
448c4c6Compare3 tasks
3 tasks
targos added a commit
to targos/node
that referenced
this pull request
Oct 21, 2017
In PR [1], a bunch of properties were removed from the error thrown by execSync and execFileSync. It turns out that some of those were still supposed to be there, as the documentation states that the error contains the entire result from the spawnSync call. [1] nodejs#13601
targos added a commit
that referenced
this pull request
Oct 23, 2017
In PR [1], a bunch of properties were removed from the error thrown by execSync and execFileSync. It turns out that some of those were still supposed to be there, as the documentation states that the error contains the entire result from the spawnSync call. [1] #13601 PR-URL: #16060 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
In PR [1], a bunch of properties were removed from the error thrown by execSync and execFileSync. It turns out that some of those were still supposed to be there, as the documentation states that the error contains the entire result from the spawnSync call. [1] nodejs/node#13601 PR-URL: nodejs/node#16060 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
In PR [1], a bunch of properties were removed from the error thrown by execSync and execFileSync. It turns out that some of those were still supposed to be there, as the documentation states that the error contains the entire result from the spawnSync call. [1] nodejs/node#13601 PR-URL: nodejs/node#16060 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that when the synchronous
child_processmethods were added, additional information such as user-provided/parsed options, etc. was being copied to the returned object. Not only is this undocumented/unexpected, but it looks like this may have only been done for the purposes of tests (to test normalized/default options for example).This PR extracts the actual sync spawning into an internal function which can then be monkey-patched as needed by tests.
I have also changed the errors returned by the
exec*Sync()methods so that it matches that of theErrorobject mutation done for the asyncexec*()methods (e.g.err.resultcontains the libuv error name for status codes less than 0).CI: https://ci.nodejs.org/job/node-test-pull-request/8593/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)