Uh oh!
There was an error while loading. Please reload this page.
test: change deprecated method to recommended - #13649
Closed
Trott wants to merge 1 commit into
Closed
Conversation
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives.
Contributor
LGTM if CI is ok: https://ci.nodejs.org/job/node-test-pull-request/8624/ |
refack
approved these changes
Jun 13, 2017
cjihrig
approved these changes
Jun 13, 2017
refack
commented
Jun 13, 2017
Contributor
ohh hello there: https://ci.nodejs.org/job/node-test-commit-freebsd/9699/nodes=freebsd11-x64/tapResults/ |
refack
commented
Jun 13, 2017
Contributor
Rerun arm-fanned (infra fixed): https://ci.nodejs.org/job/node-test-commit-arm-fanned/9387/ |
lpinca
approved these changes
Jun 13, 2017
jasnell
approved these changes
Jun 13, 2017
jasnell
left a comment
Member
There was a problem hiding this comment.
LGTM so long as we still have good test coverage on new Buffer() and Buffer()
tniessen
approved these changes
Jun 14, 2017
tniessen
left a comment
Member
There was a problem hiding this comment.
ARM is still having some unrelated problems.
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 15, 2017
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. PR-URL: nodejs#13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
Trott
commented
Jun 15, 2017
MemberAuthor
Landed in 14f5a9b |
addaleax pushed a commit
that referenced
this pull request
Jun 17, 2017
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. PR-URL: #13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
addaleax pushed a commit
that referenced
this pull request
Jun 21, 2017
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. PR-URL: #13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
MylesBorins
commented
Jul 17, 2017
Contributor
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jul 18, 2017
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. PR-URL: nodejs#13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
4 tasks
Trott
commented
Jul 18, 2017
MemberAuthor
6.x backport in #14339 |
MylesBorins pushed a commit
that referenced
this pull request
Jul 18, 2017
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. Backport-PR-URL: #14339 PR-URL: #13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test buffer stream tls zlib