Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 36.4k
test: increase timeouts on arm#1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
88558320c2210b30a188277f952ce4a5192d577d19File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -51,7 +51,7 @@ function onNoMoreLines() { | ||
| setTimeout(function testTimedOut() { | ||
| assert(false, 'test timed out.'); | ||
| }, 6000).unref(); | ||
| }, common.platformTimeout(3000)).unref(); | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This timeout seems to have been chosen too generous, so I reduced it. | ||
| process.on('exit', function onExit() { | ||
| // Kill processes in reverse order to avoid timing problems on Windows where | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -72,7 +72,7 @@ function parent() { | ||
| setTimeout(function() { | ||
| throw new Error('hang'); | ||
| }); | ||
| }, 4000).unref(); | ||
| }, common.platformTimeout(2000)).unref(); | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. | ||
| var s = spawn(node, [__filename, 'server'], opt); | ||
| var c; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an easier way:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's pretty convenient. Didn't know about these variables.