test: increase coverage for internal/module.js

[TamasHodi]

Add tests for the stripShebang function.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test internal modules

[TamasHodi]

Tests should be fine but i was not able to run them locally.
Is there any way to do that without getting Error: Cannot find module for the required internal module?
I really would like to put the last tick there. :)

[refack]

Tests should be fine but i was not able to run them locally.
Is there any way to do that without getting Error: Cannot find module for the required internal module?
I really would like to put the last tick there. :)

Both an answer and a nit: Add // Flags: --expose-internals as the first line in the test file (Example: test/parallel/test-buffer-fill.js). That will tell test.py to call node with the --expose-internals flag. You can also directly test the file with node --expose-internals test/parallel/test-internal-modules.js.

[refack]

Ohh and P.S. 😉
@TamasHodi thank you very much for the contribution 🥇

[TamasHodi]

@refack Thanks for the help! Well, Im going to read the docs next time :P
Btw ive cleaned up the tests so its ready for review.

[cjihrig]

Could you add these changes in a separate file. I don't think we want to lose the things that are currently removed in this PR.

[jasnell]

Something like the following would be far more compact (and likely easier to maintain):

[['',''],['aa','aa'],['#!',''],['#!bin/bash',''],['#!bin/bash\naa','\naa']].forEach((i)=>assert.strictEqual(internalModule.stripShebang(i[0]),i[1]));

[TamasHodi]

@cjihrig I've restored the original test file which was intended to check the availability of the internal modules and moved my refactored tests into a new file.

[refack]

CI: https://ci.nodejs.org/job/node-test-commit/10570/

[TamasHodi]

I've just seen the failing OSX test/build. Did i miss something?
The console output doesn't say that much for me as a newbie. :)

[refack]

I've just seen the failing OSX test/build. Did i miss something?
The console output doesn't say that much for me as a newbie. :)

Don't worry, it's unrelated.

[jasnell]

Landed in 83ebb6d

[refack]

@TamasHodi congradulations on landing your first contribution

After refresh

Many happy returns 😉