Uh oh!
There was an error while loading. Please reload this page.
src: don't set --icu_case_mapping flag on startup - #13698
Merged
Conversation
refack
approved these changes
Jun 15, 2017
benjamingr
approved these changes
Jun 15, 2017
cjihrig
approved these changes
Jun 15, 2017
jasnell
approved these changes
Jun 15, 2017
watilde
approved these changes
Jun 19, 2017
jungshik
commented
Jun 21, 2017
When can this be merged? It's blocking a V8 change to remove the flag because V8 cq has a node js trybot. |
bnoordhuis
commented
Jun 21, 2017
MemberAuthor
I'll merge it. |
It's on by default now and the flag will be removed in the near future. Fixes: nodejs#13688 PR-URL: nodejs#13698 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
addaleax pushed a commit
that referenced
this pull request
Jun 21, 2017
It's on by default now and the flag will be removed in the near future. Fixes: #13688 PR-URL: #13698 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
1 task
MylesBorins
commented
Jul 17, 2017
Contributor
Should this be backported to v6.x? |
bnoordhuis
commented
Jul 17, 2017
MemberAuthor
Doesn't apply to v6.x, I've added labels. |
hferreiro pushed a commit
to brave/node
that referenced
this pull request
Nov 3, 2017
It's on by default now and the flag will be removed in the near future. Fixes: nodejs/node#13688 PR-URL: nodejs/node#13698 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's on by default now and the flag will be removed in the near future.
Fixes: #13688
CI: https://ci.nodejs.org/job/node-test-pull-request/8675/