Uh oh!
There was an error while loading. Please reload this page.
lib: remove the invalid command line options - #13764
Closed
JacksonTian wants to merge 1 commit into
Closed
Conversation
addaleax
commented
Jun 18, 2017
Member
LGTM but I’d combine this into #13763. |
JacksonTian
commented
Jun 19, 2017
ContributorAuthor
addaleax
approved these changes
Jun 19, 2017
cjihrig
approved these changes
Jun 19, 2017
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The commit message title should probably mention command line flags. It's not clear just from the title what "entries" are.
jasnell
approved these changes
Jun 19, 2017
JacksonTian
commented
Jun 20, 2017
ContributorAuthor
Updated the commit title. |
mhdawson
approved these changes
Jun 20, 2017
The option --remote_debugging_server and --debug-agent are not supported now.
BridgeAR
approved these changes
Aug 30, 2017
BridgeAR
commented
Aug 30, 2017
Member
Landed in 9f175d1 |
BridgeAR pushed a commit
that referenced
this pull request
Aug 30, 2017
The option --remote_debugging_server and --debug-agent are not supported now. PR-URL: #13764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
cjihrig pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
The option --remote_debugging_server and --debug-agent are not supported now. PR-URL: nodejs#13764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
The option --remote_debugging_server and --debug-agent are not supported now. PR-URL: nodejs/node#13764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
Sep 10, 2017
The option --remote_debugging_server and --debug-agent are not supported now. PR-URL: #13764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Sep 12, 2017
The option --remote_debugging_server and --debug-agent are not supported now. PR-URL: #13764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option --remote_debugging_server and --debug-agent are
not supported now.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib/internal/bootstrap_node