Skip to content

dns: make var to const if possible - #13797

Closed
XadillaX wants to merge 1 commit into
nodejs:masterfrom
XadillaX:feature/dns-var-to-const
Closed

dns: make var to const if possible#13797
XadillaX wants to merge 1 commit into
nodejs:masterfrom
XadillaX:feature/dns-var-to-const

Conversation

@XadillaX

@XadillaXXadillaX commented Jun 19, 2017

Copy link
Copy Markdown
Contributor

Refs: #13732

Checklist
Affected core subsystem(s)

dns

@nodejs-github-botnodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label Jun 19, 2017
@XadillaX

Copy link
Copy Markdown
ContributorAuthor

How about var to let?

@XadillaX

Copy link
Copy Markdown
ContributorAuthor

duplicate with #13756

@gibfahn

Copy link
Copy Markdown
Member

How about var to let?

I think the gating factor is whether there will be deoptimisations in V8. If you check and confirm that there won't be then I don't see the harm in raising a PR (and I'd be +1 on it). If we move away from var entirely we can use the no-var and prefer-const eslint rules.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dnsIssues and PRs related to the dns subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@XadillaX@gibfahn@nodejs-github-bot