Skip to content

tools: add eslint rule for inspector checking - #13814

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:inspector-eslint-rule
Closed

tools: add eslint rule for inspector checking#13814
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:inspector-eslint-rule

Conversation

@danbev

Copy link
Copy Markdown
Contributor

The motivation for this commit is to pick up early on missing checks for
inspector support (when Node is built --without-inspector).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

The motivation for this commit is to pick up early on missing checks for
inspector support (when Node is built --without-inspector).
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 20, 2017
@danbev

Copy link
Copy Markdown
ContributorAuthor

@vsemozhetbytvsemozhetbyt added the test Issues and PRs related to the tests. label Jun 20, 2017
@cjihrig

Copy link
Copy Markdown
Contributor

It would be nice to combine this with the rule in #13813.

@danbev

Copy link
Copy Markdown
ContributorAuthor

It would be nice to combine this with the rule in #13813.

I thought it might make it easier to review and maintain having them as separate rules. But I can merge them together if that is preferred.

@cjihrig

Copy link
Copy Markdown
Contributor

I think they are similar enough that the rule can be parameterized. They're both checking "if module X is required, make sure there is an if statement to skip the test."

@danbev

Copy link
Copy Markdown
ContributorAuthor

I think they are similar enough that the rule can be parameterized. They're both checking "if module X is required, make sure there is an if statement to skip the test."

I'll give it a try, closing this for now.

@danbevdanbev closed this Jun 20, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@danbev@cjihrig@vsemozhetbyt@nodejs-github-bot