Skip to content

process: use internal/errors in internalNextTick - #13982

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:next-tick-internal-error
Closed

process: use internal/errors in internalNextTick#13982
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:next-tick-internal-error

Conversation

@tniessen

@tniessentniessen commented Jun 29, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Refs: #12892
Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

@nodejs-github-botnodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jun 29, 2017
@tniessentniessen added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 29, 2017
@jasnelljasnell mentioned this pull request Jun 30, 2017
Closed
80 tasks
@tniessentniessen self-assigned this Jun 30, 2017
@tniessen

tniessen commented Jul 2, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 3129b2c

@tniessentniessen closed this Jul 2, 2017
tniessen added a commit that referenced this pull request Jul 2, 2017
@tniessen
process: use internal/errors in internalNextTick
3129b2c
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
@tniessen@addaleax
process: use internal/errors in internalNextTick
858c14e
PR-URL: nodejs#13982
Refs: nodejs#12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleaxaddaleax mentioned this pull request Jul 3, 2017
Merged
@mhdawson

mhdawson commented Jul 6, 2017

Copy link
Copy Markdown
Member

@jasnell I think this should have been marked as SemVer major, will add please remove if thats incorrect.

@mhdawsonmhdawson added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 6, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@tniessen@addaleax
process: use internal/errors in internalNextTick
3a65c09
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@tniessen@addaleax
process: use internal/errors in internalNextTick
539f4c0
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnelljasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

@tniessentniessen

Labels

errorsIssues and PRs related to JavaScript errors originated in Node.js core.processIssues and PRs related to the process subsystem.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen@mhdawson@jasnell@lpinca@nodejs-github-bot