v8: fix process.abort() interaction with V8 by addaleax · Pull Request #13985 · nodejs/node

addaleax · 2017-06-29T11:47:10Z

Since V8 5.9 V8 installs a default signal handler for some signals
when creating a default platform instance that prints a stack trace.

However, Node already does the same thing, so it would seem like the
two different stack traces would be printed; also, the V8 handler
would lead to a SIGSEGV under some circumstances, rather than
letting the abort continue normally.

Fixes: #13865

@nodejs/v8 I don’t have the time to deal with any upstream concerns regarding this, and probably not to look into the segfault as well, so if we want to report it/have that V8 change reverted, somebody else needs to do it.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

v8

CI: https://ci.nodejs.org/job/node-test-pull-request/8862/

refack · 2017-06-29T11:51:17Z

Maybe also remove the FLAKY marker from https://github.com/nodejs/node/blob/master/test/async-hooks/async-hooks.status (at least the linux one)

refack · 2017-06-29T11:56:37Z

Yay, it works.

bnoordhuis · 2017-06-29T11:59:43Z

See v8/v8@3f45368, it was made configurable upstream. We should probably just cherry-pick that patch.

API/ABI stability is not a concern because libplatform and v8::Platform is not something add-ons use.

Original commit message: d8: Make in process stack dumping optional Adds a flag (--disable-in-process-stack-traces) to not install signal handlers so that e.g. ASan signal handlers will work. This flag mirrors chromium's one. R=jochen@chromium.org BUG=chromium:716235 Review-Url: https://codereview.chromium.org/2854173002 Cr-Commit-Position: refs/heads/master@{nodejs#45142} PR-URL: nodejs#13985

addaleax · 2017-06-29T12:27:12Z

@bnoordhuis Thanks for the pointer; I’ve updated this.

CI: https://ci.nodejs.org/job/node-test-commit/10814/

bnoordhuis

LGTM with a comment.

bnoordhuis · 2017-06-29T12:50:52Z

This should probably go into test/abort. I'm kind of surprised to discover that the test from #12914 went into test/parallel, that seems wrong. (edit: oh wait, that test only runs on Windows.)

Just for context: because of the core dumps taking up storage?

Same goes for async_hooks/test-callback-error.js. But it is problematic that we don't have any abort tests running on CI, it is only because we put async_hooks/test-callback-error.js in the wrong directory that we discovered this bug.

I’ve moved the file.

But it is problematic that we don't have any abort tests running on CI, it is only because we put async_hooks/test-callback-error.js in the wrong directory that we discovered this bug.
I wonder if @nodejs/build can set up a single machine that is suitable to run those tests. Not sure what is required: That it be configured to not write core dumps? Or that it have a large enough disk to write core dumps and has a clean up task to delete them when the tests are done?
Anyway, if it's possible, maybe CI runs can at least run the tests in abort on a single platform, which is better than not running them at all ever. And it might make a good prototype for also running pummel and maybe even internet tests...

That it be configured to not write core dumps?
That would be the easiest, I guess. I don’t see why we wouldn’t be able to just do that in the test runner:
importresourceresource.setrlimit(resource.RLIMIT_CORE, (0,0))

I wonder if @nodejs/build can set up a single machine that is suitable to run those tests.
IMHO it won't be enough... there have been at least 3 abort related fixes in the last couple of weeks, on three different platforms...
An alternative might be a programmatic way to delete the core-dumps from within the test a la common.refreshTmpDir()

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. Fixes: nodejs#13865

jasnell

Largely rubber stamp LGTM

Trott · 2017-06-30T20:10:41Z

This fixes test/abort/test-abort-backtrace.js, so there's one more reason to believe that running those tests somewhere regularly might be useful.

Trott · 2017-07-02T22:46:19Z

Landed in 31349e2 and 4dff05f

Trott · 2017-07-02T22:46:53Z

A @refack-inspired post-land CI run: https://ci.nodejs.org/job/node-test-commit/10894/

refack · 2017-07-02T22:51:49Z

A @refack-inspired post-land CI run: https://ci.nodejs.org/job/node-test-commit/10894/

YAY for the land! With npm-install of PI3 back to passing, we might have a green CI 💃
P.S. for general sanity I just run linuxone (it finished in < 3 minutes 😄), but this one might actualy turn green, and that's totally worth it.

Trott · 2017-07-02T22:52:21Z

I think #14029 still has to land before we get to green.

Original commit message: d8: Make in process stack dumping optional Adds a flag (--disable-in-process-stack-traces) to not install signal handlers so that e.g. ASan signal handlers will work. This flag mirrors chromium's one. R=jochen@chromium.org BUG=chromium:716235 Review-Url: https://codereview.chromium.org/2854173002 Cr-Commit-Position: refs/heads/master@{nodejs#45142} PR-URL: nodejs#13985 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. PR-URL: nodejs#13985Fixes: nodejs#13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: d8: Make in process stack dumping optional Adds a flag (--disable-in-process-stack-traces) to not install signal handlers so that e.g. ASan signal handlers will work. This flag mirrors chromium's one. R=jochen@chromium.org BUG=chromium:716235 Review-Url: https://codereview.chromium.org/2854173002 Cr-Commit-Position: refs/heads/master@{#45142} PR-URL: #13985 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. PR-URL: #13985Fixes: #13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: d8: Make in process stack dumping optional Adds a flag (--disable-in-process-stack-traces) to not install signal handlers so that e.g. ASan signal handlers will work. This flag mirrors chromium's one. R=jochen@chromium.org BUG=chromium:716235 Review-Url: https://codereview.chromium.org/2854173002 Cr-Commit-Position: refs/heads/master@{#45142} PR-URL: #13985 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. PR-URL: #13985Fixes: #13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: d8: Make in process stack dumping optional Adds a flag (--disable-in-process-stack-traces) to not install signal handlers so that e.g. ASan signal handlers will work. This flag mirrors chromium's one. R=jochen@chromium.org BUG=chromium:716235 Review-Url: https://codereview.chromium.org/2854173002 Cr-Commit-Position: refs/heads/master@{nodejs#45142} PR-URL: nodejs#13985 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. PR-URL: nodejs#13985Fixes: nodejs#13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: d8: Make in process stack dumping optional Adds a flag (--disable-in-process-stack-traces) to not install signal handlers so that e.g. ASan signal handlers will work. This flag mirrors chromium's one. R=jochen@chromium.org BUG=chromium:716235 Review-Url: https://codereview.chromium.org/2854173002 Cr-Commit-Position: refs/heads/master@{#45142} PR-URL: #13985 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. PR-URL: #13985Fixes: #13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. PR-URL: nodejs#13985Fixes: nodejs#13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. Backport-PR-URL: #14574 Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net> Backport-Reviewed-By: Refael Ackermann <refack@gmail.com> PR-URL: #13985Fixes: #13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2017-08-16T08:33:11Z

assuming this doesn't apply to v6.x and 5.1. LMK if I'm mistaken

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace. However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a `SIGSEGV` under some circumstances, rather than letting the abort continue normally. Resolve this by disabling V8’s signal handler by default. PR-URL: nodejs/node#13985Fixes: nodejs/node#13865 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jun 29, 2017

addaleax mentioned this pull request Jun 29, 2017
Investigate SIGSEGV from test/async-hooks/test-callback-error #13865
Closed

addaleax force-pushed the process-abort-v859 branch from e8f4977 to 6f5a794Compare June 29, 2017 12:16

bnoordhuis approved these changes Jun 29, 2017
View reviewed changes

refack mentioned this pull request Jun 29, 2017
test: mark test-fs-readdir-ucs2 flaky #13989
Closed
2 tasks

cjihrig approved these changes Jun 29, 2017
View reviewed changes

addaleax force-pushed the process-abort-v859 branch from 6f5a794 to 9ca4062Compare June 30, 2017 10:05

bnoordhuis mentioned this pull request Jun 30, 2017
src: Node implementation of v8::Platform #14001
Closed
3 tasks

jasnell approved these changes Jun 30, 2017
View reviewed changes

refack mentioned this pull request Jun 30, 2017
test: implement a way to regularly test abort behaviour on all platform #14012
Closed

Trott mentioned this pull request Jun 30, 2017
test: run abort tests #14013
Closed
2 tasks

Trott closed this Jul 2, 2017

addaleax mentioned this pull request Jul 3, 2017
SIGILL when using abort-on-uncaught-exception #14060
Closed

addaleax mentioned this pull request Jul 3, 2017
v8.2.0 proposal #13744
Merged

addaleax mentioned this pull request Jul 24, 2017
v8.3.0 proposal #14452
Closed

addaleax added the backported-to-v8.x label Aug 2, 2017

addaleax mentioned this pull request Aug 2, 2017
v8.3.0 proposal #14594
Merged

MylesBorins added the dont-land-on-v6.x label Aug 16, 2017

addaleax deleted the process-abort-v859 branch August 16, 2017 08:40

jasnell mentioned this pull request Oct 30, 2017
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135
Merged

Uh oh!

Uh oh!

Conversation

addaleax commented Jun 29, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

refack commented Jun 29, 2017

Uh oh!

refack commented Jun 29, 2017

Uh oh!

bnoordhuis commented Jun 29, 2017

Uh oh!

addaleax commented Jun 29, 2017

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuisJun 29, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

refackJun 29, 2017

Choose a reason for hiding this comment

Uh oh!

bnoordhuisJun 29, 2017

Choose a reason for hiding this comment

Uh oh!

AndreasMadsenJun 30, 2017

Choose a reason for hiding this comment

Uh oh!

addaleaxJun 30, 2017

Choose a reason for hiding this comment

Uh oh!

TrottJun 30, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

addaleaxJun 30, 2017

Choose a reason for hiding this comment

Uh oh!

refackJun 30, 2017

Choose a reason for hiding this comment

Uh oh!

refackJun 30, 2017

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Jun 30, 2017

Uh oh!

Trott commented Jul 2, 2017

Uh oh!

Trott commented Jul 2, 2017

Uh oh!

refack commented Jul 2, 2017

Uh oh!

Trott commented Jul 2, 2017

Uh oh!

MylesBorins commented Aug 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

addaleax commented Jun 29, 2017•
edited
Loading

bnoordhuisJun 29, 2017•
edited
Loading

TrottJun 30, 2017•
edited
Loading