Skip to content

test: add get/set effective uid/gid tests - #14091

Closed
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:getseteuidtests
Closed

test: add get/set effective uid/gid tests#14091
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:getseteuidtests

Conversation

@evanlucas

@evanlucasevanlucas commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

3c92ca2 should have had tests to go along with it.
This adds tests for the following functions:

  • process.geteuid()
  • process.seteuid()
  • process.getegid()
  • process.setegid()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@evanlucas
test: add get/set effective uid/gid tests
796cfb3
3c92ca2 should have had tests
to go along with it. This adds tests for the following functions:
* `process.geteuid()`
* `process.seteuid()`
* `process.getegid()`
* `process.setegid()`
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 5, 2017
@evanlucas

evanlucas commented Jul 5, 2017

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/8991/

@mscdexmscdex added the process Issues and PRs related to the process subsystem. label Jul 5, 2017
refack
refack approved these changes Jul 7, 2017
View reviewed changes

@refackrefack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows clause LGTM 😏
Semi-Rubberstamp the "else"

evanlucas added a commit to evanlucas/node that referenced this pull request Jul 11, 2017
@evanlucas
test: add get/set effective uid/gid tests
80c9fd9
3c92ca2 should have had tests
to go along with it. This adds tests for the following functions:
* `process.geteuid()`
* `process.seteuid()`
* `process.getegid()`
* `process.setegid()`
PR-URL: nodejs#14091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas

evanlucas commented Jul 11, 2017

Copy link
Copy Markdown
ContributorAuthor

Landed in 80c9fd9. Thanks!

addaleax pushed a commit that referenced this pull request Jul 11, 2017
@evanlucas@addaleax
test: add get/set effective uid/gid tests
f457b05
3c92ca2 should have had tests
to go along with it. This adds tests for the following functions:
* `process.geteuid()`
* `process.seteuid()`
* `process.getegid()`
* `process.setegid()`
PR-URL: #14091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleaxaddaleax mentioned this pull request Jul 11, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@evanlucas@addaleax
test: add get/set effective uid/gid tests
697ea62
3c92ca2 should have had tests
to go along with it. This adds tests for the following functions:
* `process.geteuid()`
* `process.seteuid()`
* `process.getegid()`
* `process.setegid()`
PR-URL: #14091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@evanlucas@Fishrock123
test: add get/set effective uid/gid tests
8887a57
3c92ca2 should have had tests
to go along with it. This adds tests for the following functions:
* `process.geteuid()`
* `process.seteuid()`
* `process.getegid()`
* `process.setegid()`
PR-URL: #14091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@evanlucas@MylesBorins
test: add get/set effective uid/gid tests
5c3fd35
3c92ca2 should have had tests
to go along with it. This adds tests for the following functions:
* `process.geteuid()`
* `process.seteuid()`
* `process.getegid()`
* `process.setegid()`
PR-URL: #14091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@evanlucas@MylesBorins
test: add get/set effective uid/gid tests
40a61e1
3c92ca2 should have had tests
to go along with it. This adds tests for the following functions:
* `process.geteuid()`
* `process.seteuid()`
* `process.getegid()`
* `process.setegid()`
PR-URL: #14091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@refackrefackrefack approved these changes
@claudiorodriguezclaudiorodriguezclaudiorodriguez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

processIssues and PRs related to the process subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@evanlucas@refack@jasnell@cjihrig@claudiorodriguez@mscdex@MylesBorins@nodejs-github-bot