Uh oh!
There was an error while loading. Please reload this page.
n-api: wrap test macros in do/while - #14095
Closed
kfarnung wants to merge 1 commit into
Closed
Conversation
kfarnung
commented
Jul 5, 2017
ContributorAuthor
jasongin
approved these changes
Jul 5, 2017
cjihrig
approved these changes
Jul 6, 2017
TimothyGu
approved these changes
Jul 6, 2017
bnoordhuis
approved these changes
Jul 6, 2017
digitalinfinity
approved these changes
Jul 6, 2017
danbev
approved these changes
Jul 7, 2017
jasnell
approved these changes
Jul 10, 2017
mhdawson
commented
Jul 11, 2017
Member
mhdawson
commented
Jul 11, 2017
Member
Created issue for failure on windows, believe its unrelated - #14178 |
mhdawson
commented
Jul 11, 2017
Member
Created issue for failure on smartos believe it is unrelated: #14177 |
mhdawson
commented
Jul 12, 2017
Member
Lots of red in CI, but failures are all known issues, going to land. |
mhdawson pushed a commit
that referenced
this pull request
Jul 12, 2017
PR-URL: #14095 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mhdawson
commented
Jul 12, 2017
Member
Landed as f52c707 |
Merged
addaleax pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #14095 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit
that referenced
this pull request
Jul 19, 2017
PR-URL: #14095 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gabrielschulhof pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
PR-URL: nodejs#14095 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 16, 2018
Backport-PR-URL: #19447 PR-URL: #14095 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api