Uh oh!
There was an error while loading. Please reload this page.
build: split up cpplint to avoid long cmd lines - #14116
Closed
kfarnung wants to merge 1 commit into
Closed
Conversation
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies.
kfarnung
commented
Jul 6, 2017
ContributorAuthor
/cc @refack Upstream port of nodejs/node-chakracore#330 |
2 tasks
refack
approved these changes
Jul 6, 2017
refack
commented
Jul 6, 2017
Contributor
kunalspathak
approved these changes
Jul 7, 2017
joaocgreis
approved these changes
Jul 9, 2017
joaocgreis
left a comment
Member
There was a problem hiding this comment.
LGTM, I confirmed that this is runs the same commands as before.
joaocgreis
commented
Jul 9, 2017
Member
CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/9048/ (I don't see a way for failures outside test-windows to be related, but every PR must have a full CI run) |
refack pushed a commit
to refack/node
that referenced
this pull request
Jul 9, 2017
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. PR-URL: nodejs#14116 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: João Reis <reis@janeasystems.com>
refack
commented
Jul 9, 2017
Contributor
Landed in d48472c |
Contributor
Windows Sanity: https://ci.nodejs.org/job/node-test-commit-windows-fanned/10290/ ✔️ |
addaleax pushed a commit
that referenced
this pull request
Jul 11, 2017
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. PR-URL: #14116 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: João Reis <reis@janeasystems.com>
Merged
addaleax pushed a commit
that referenced
this pull request
Jul 18, 2017
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. PR-URL: #14116 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: João Reis <reis@janeasystems.com>
Fishrock123 pushed a commit
that referenced
this pull request
Jul 19, 2017
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. PR-URL: #14116 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: João Reis <reis@janeasystems.com>
MylesBorins
commented
Aug 16, 2017
Contributor
Should this be backported to |
kfarnung
commented
Aug 16, 2017
ContributorAuthor
@MylesBorins this should not be needed downlevel. The fix was primarily to allow deps (in this case chakrashim) to be able to have their own lint run without exceeding the Windows command line limit. @refack do you agree? |
refack
commented
Aug 16, 2017
Contributor
Not needed but harmless to backport and even a tiny bit beneficial, if only to reduce disparity between the versions. |
kfarnung
commented
Aug 16, 2017
ContributorAuthor
I'll take care of it today. |
kfarnung added a commit
to kfarnung/node
that referenced
this pull request
Aug 16, 2017
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. PR-URL: nodejs#14116 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: João Reis <reis@janeasystems.com>
2 tasks
MylesBorins pushed a commit
that referenced
this pull request
Sep 19, 2017
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. Backport-PR-URL: #14879 PR-URL: #14116 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: João Reis <reis@janeasystems.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build