Uh oh!
There was an error while loading. Please reload this page.
test: improve the test common documentation - #14148
Closed
BridgeAR wants to merge 2 commits into
Closed
Conversation
vsemozhetbyt
approved these changes
Jul 9, 2017
| [MDN-Function]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Normal_objects_and_functions | ||
| [internationalization]: https://github.com/nodejs/node/wiki/Intl | ||
| [<Array>]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array |
Contributor
There was a problem hiding this comment.
A nit: if we use an ASCII sorting for references, should not the [<...] ones precede the [internationalization]?
refack
approved these changes
Jul 9, 2017
refack
commented
Jul 9, 2017
Contributor
/cc @nodejs/documentation @nodejs/testing |
gibfahn
approved these changes
Jul 10, 2017
MemberAuthor
Comment addressed |
cjihrig
approved these changes
Jul 10, 2017
benjamingr
approved these changes
Jul 10, 2017
jasnell
approved these changes
Jul 10, 2017
TimothyGu
approved these changes
Jul 13, 2017
TimothyGu
commented
Jul 13, 2017
Member
Landed in 5ffb5b6. |
TimothyGu pushed a commit
that referenced
this pull request
Jul 13, 2017
PR-URL: #14148 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Jul 24, 2017
PR-URL: nodejs#14148 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins
commented
Nov 16, 2017
Contributor
Should this be backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better readability and less duplication (in case a link would ever change).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test