Skip to content

doc: update umask for clarity - #14170

Closed
jsumners wants to merge 2 commits into
nodejs:masterfrom
jsumners:umask-doc
Closed

doc: update umask for clarity#14170
jsumners wants to merge 2 commits into
nodejs:masterfrom
jsumners:umask-doc

Conversation

@jsumners

@jsumnersjsumners commented Jul 11, 2017•
edited by gibfahn
Loading

Copy link
Copy Markdown
Contributor

This PR clarifies the documentation for process.umask. It resolves issue #14169.

Checklist
Affected core subsystem(s)

doc

Fixes: #14169

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Jul 11, 2017
cjihrig
cjihrig approved these changes Jul 11, 2017
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

Comment threaddoc/api/process.md Outdated
creation mask. Child processes inherit the mask from the parent process. The old
mask is return if the `mask` argument is given, otherwise returns the current
mask.
creation mask. Child processes inherit the mask from the parent process. Invoked without an argument, the current mask is returned, otherwise the umask is set to the argument value and the previous mask is returned.

@cjihrigcjihrigJul 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap lines at 80 characters.

@gibfahn

gibfahn commented Jul 11, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Could you add a Fixes line to the first commit?

doc: update umask for clarity
Fixes: https://github.com/nodejs/node/issues/14169

Fixes: #14169

@jsumners

jsumners commented Jul 12, 2017

Copy link
Copy Markdown
ContributorAuthor

I don't know how to do that.

@gibfahn

gibfahn commented Jul 12, 2017

Copy link
Copy Markdown
Member

I don't know how to do that.

no problem, it can be done by whoever lands the PR.

Also @refack just pointed out to me that our PR metadata generator picks it up from the first comment message, so I just put in there instead.

gireeshpunathil
gireeshpunathil approved these changes Jul 12, 2017
View reviewed changes

@gireeshpunathilgireeshpunathil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this polymorphic return style appeared in as early as 1970's in the CAS instructions.

@jsumners

jsumners commented Jul 12, 2017

Copy link
Copy Markdown
ContributorAuthor

@gireeshpunathil the issue wasn't about the functionality of the function. It was the description of that functionality.

jasnell pushed a commit that referenced this pull request Jul 14, 2017
@jsumners@jasnell
doc: update umask for clarity
dce2f06
PR-URL: #14170Fixes: #14169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jul 14, 2017

Copy link
Copy Markdown
Member

Landed in dce12f06

@jasnelljasnell closed this Jul 14, 2017
@addaleaxaddaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@jsumners@addaleax
doc: update umask for clarity
e91a7a4
PR-URL: #14170Fixes: #14169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@jsumners@Fishrock123
doc: update umask for clarity
b344687
PR-URL: #14170Fixes: #14169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@jsumners@MylesBorins
doc: update umask for clarity
7bf6f24
PR-URL: #14170Fixes: #14169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@jsumners@MylesBorins
doc: update umask for clarity
98466c5
PR-URL: #14170Fixes: #14169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@jsumners@MylesBorins
doc: update umask for clarity
b0286ac
PR-URL: #14170Fixes: #14169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
@beevelopbeevelop mentioned this pull request Sep 6, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+2 more reviewers
@refackrefackrefack approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: process.umask doc unclear

9 participants

@jsumners@gibfahn@jasnell@refack@lpinca@cjihrig@gireeshpunathil@MylesBorins@nodejs-github-bot