Skip to content

deps: cherry-pick 6cb999b97b from V8 upstream - #14188

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:v8-jest-fix
Closed

deps: cherry-pick 6cb999b97b from V8 upstream#14188
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:v8-jest-fix

Conversation

@addaleax

@addaleaxaddaleax commented Jul 12, 2017

Copy link
Copy Markdown
Member

“This will not be merged to 5.9.” → I’m opening this cherry-pick.

Original commit message:

Properly handle loads from global interceptor via prototype chain.
... when receiver is in dictionary mode.
Bug: v8:6490
Change-Id: Ic5a8d214adcc4efd4cb163cbc6b351c4e6b596af
Reviewed-on: https://chromium-review.googlesource.com/559548
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46428}

Ref: https://chromium.googlesource.com/v8/v8.git/+/6cb999b97b7953ebfd4aabf2e1f62bf405f21c69
Fixes: #13804

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

deps/v8

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jul 12, 2017
@addaleax

addaleax commented Jul 12, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-commit/11073/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/777/

/cc @targos

@addaleaxaddaleax mentioned this pull request Jul 12, 2017
Merged
@targostargos mentioned this pull request Jul 12, 2017
Closed
8 tasks
@addaleax

addaleax commented Jul 14, 2017

Copy link
Copy Markdown
MemberAuthor

Let’s try that again:

CI: https://ci.nodejs.org/job/node-test-commit/11111/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/785/

@targos

targos commented Jul 14, 2017

Copy link
Copy Markdown
Member

V8 CI is broken. I opened #14219 to fix it

@isheludko@addaleax
deps: cherry-pick 6cb999b97b from V8 upstream
046031e
Original commit message:
Properly handle loads from global interceptor via prototype chain.
... when receiver is in dictionary mode.
Bug: v8:6490
Change-Id: Ic5a8d214adcc4efd4cb163cbc6b351c4e6b596af
Reviewed-on: https://chromium-review.googlesource.com/559548
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#46428}
Ref: https://chromium.googlesource.com/v8/v8.git/+/6cb999b97b7953ebfd4aabf2e1f62bf405f21c69Fixes: nodejs#13804
PR-URL: nodejs#14188
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax

addaleax commented Jul 14, 2017

Copy link
Copy Markdown
MemberAuthor

@targos Thank you!

V8 CI, new try: https://ci.nodejs.org/job/node-test-commit-v8-linux/786/

jasnell
jasnell approved these changes Jul 14, 2017
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber-stampy LGTM

@addaleax

addaleax commented Jul 15, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 785a9e5

@addaleax
addaleax deleted the v8-jest-fix branch July 15, 2017 04:21
addaleax pushed a commit that referenced this pull request Jul 15, 2017
@isheludko@addaleax
deps: cherry-pick 6cb999b97b from V8 upstream
785a9e5
Original commit message:
Properly handle loads from global interceptor via prototype chain.
... when receiver is in dictionary mode.
Bug: v8:6490
Change-Id: Ic5a8d214adcc4efd4cb163cbc6b351c4e6b596af
Reviewed-on: https://chromium-review.googlesource.com/559548
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46428}
Ref: https://chromium.googlesource.com/v8/v8.git/+/6cb999b97b7953ebfd4aabf2e1f62bf405f21c69Fixes: #13804
PR-URL: #14188
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refackrefack mentioned this pull request Jul 16, 2017
Closed
3 tasks
addaleax pushed a commit that referenced this pull request Jul 24, 2017
@isheludko@addaleax
deps: cherry-pick 6cb999b97b from V8 upstream
577b4f7
Original commit message:
Properly handle loads from global interceptor via prototype chain.
... when receiver is in dictionary mode.
Bug: v8:6490
Change-Id: Ic5a8d214adcc4efd4cb163cbc6b351c4e6b596af
Reviewed-on: https://chromium-review.googlesource.com/559548
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46428}
Ref: https://chromium.googlesource.com/v8/v8.git/+/6cb999b97b7953ebfd4aabf2e1f62bf405f21c69Fixes: #13804
PR-URL: #14188
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to targos/node that referenced this pull request Jul 24, 2017
@isheludko@addaleax
deps: cherry-pick 6cb999b97b from V8 upstream
646eff0
Original commit message:
Properly handle loads from global interceptor via prototype chain.
... when receiver is in dictionary mode.
Bug: v8:6490
Change-Id: Ic5a8d214adcc4efd4cb163cbc6b351c4e6b596af
Reviewed-on: https://chromium-review.googlesource.com/559548
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#46428}
Ref: https://chromium.googlesource.com/v8/v8.git/+/6cb999b97b7953ebfd4aabf2e1f62bf405f21c69Fixes: nodejs#13804
PR-URL: nodejs#14188
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnelljasnell mentioned this pull request Oct 30, 2017
Merged
@MylesBorins

MylesBorins commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes

Assignees

No one assigned

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax@targos@MylesBorins@bnoordhuis@jasnell@nodejs-github-bot@isheludko