Uh oh!
There was an error while loading. Please reload this page.
buffer: fix indentation nits - #14224
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Fix indentation issues that will be flagged by upcoming stricter linting.
lpinca
approved these changes
Jul 13, 2017
cjihrig
approved these changes
Jul 13, 2017
refack
approved these changes
Jul 13, 2017
targos
approved these changes
Jul 14, 2017
jasnell
approved these changes
Jul 14, 2017
Trott
commented
Jul 15, 2017
MemberAuthor
Trott
commented
Jul 17, 2017
MemberAuthor
Landed in e0340af |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jul 17, 2017
Fix indentation issues that will be flagged by upcoming stricter linting. PR-URL: nodejs#14224 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
commented
Jul 24, 2017
Member
This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the |
Trott
commented
Jul 24, 2017
MemberAuthor
This depends on #13976 which is semver-major, so I'm going to mark it as dont-land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix indentation issues that will be flagged by upcoming stricter
linting.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
buffer tools