Skip to content

deps: upgrade npm to 5.3.0 - #14235

Closed
zkat wants to merge 3 commits into
nodejs:masterfrom
npm:npm-5.3.0
Closed

deps: upgrade npm to 5.3.0#14235
zkat wants to merge 3 commits into
nodejs:masterfrom
npm:npm-5.3.0

Conversation

@zkat

@zkatzkat commented Jul 14, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
  • build
Description of Changes

Hey y'all! This release is a bit of a doozy:

  • It includes a ton of bugfixes that should seriously stabilize npm after that big 5.0 release (more coming!). A bunch of folks who couldn't use npm5 are now able to use it!
  • A semver-minor bump with several small feature additions because technically-semver
  • Another semver-minor bump that adds of npx to the primary npm distribution. This change in particular required modification of the node installers, based on the discussion in deps: Including additional binaries with npm? #13640.
  • A standalone hotfix bump to npx to bring it up to 9.2.1 (which works on Windows)

This PR supersedes #14163. Tests should actually be passing now. 👼

Changelogs

cc @Fishrock123@refack@MylesBorins@addaleax

@nodejs-github-botnodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jul 14, 2017
@zkatzkat mentioned this pull request Jul 14, 2017
4 tasks

@Fishrock123Fishrock123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, not sure what else to say

This includes a critical fix to get npx working on Windows
@zkat

zkat commented Jul 15, 2017

Copy link
Copy Markdown
ContributorAuthor

Heads-up: I added a hotfix commit that bumps npx to 9.2.1, which is a small patch to get npx working again on Windows (oops). It'll be included with the next npm release, but I figure it'd be nice to make sure the one y'all are shipping actually works on windows. 😳

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@jasnell

Copy link
Copy Markdown
Member

Failures in CI look unrelated.

jasnell pushed a commit that referenced this pull request Jul 17, 2017
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Jul 17, 2017
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Jul 17, 2017
This includes a critical fix to get npx working on Windows
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jul 17, 2017

Copy link
Copy Markdown
Member

Landed in 24f4390, 62779ae and cb8cefd

[refack] replaced 62779ae with full hash becuase GitHub is lazy

@jasnelljasnell closed this Jul 17, 2017
@MylesBorins

MylesBorins commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

Did we confirm that npx installs into the system path as expected?

edit: can confirm it working using configure / make -j4 install... will check for double click installer as well

@zkat
zkat deleted the npm-5.3.0 branch July 17, 2017 20:48
@refack

Copy link
Copy Markdown
Contributor

Did we confirm that npx installs into the system path as expected?

Windows MSI ✔️

@addaleaxaddaleax added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. labels Jul 18, 2017
@addaleaxaddaleax mentioned this pull request Jul 18, 2017
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
This includes a critical fix to get npx working on Windows
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jul 18, 2017
Notable changes:
* **Async Hooks**
* Multiple improvements to Promise support in `async_hooks` have been made.
* **Build**
* The compiler version requirement to build Node with GCC has been raised to
GCC 4.9.4.
[[`820b011ed6`](820b011ed6)]
[#13466](#13466)
* **Cluster**
* Users now have more fine-grained control over the inspector port used by
individual cluster workers. Previously, cluster workers would simply
increment from the master's debug port.
[[`dfc46e262a`](dfc46e262a)]
[#14140](#14140)
* **DNS**
* The server used for DNS queries can now use a custom port.
[[`ebe7bb29aa`](ebe7bb29aa)]
[#13723](#13723)
* Support for `dns.resolveAny()` has been added.
[[`6e30e2558e`](6e30e2558e)]
[#13137](#13137)
* **npm**
* The `npm` CLI has been updated to version 5.3.0. In particular, it now comes
with the `npx` binary, which is also shipped with Node.
[[`dc3f6b9ac1`](dc3f6b9ac1)]
[#14235](#14235)
* `npm` Changelogs:
- [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4)
- [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0)
- [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0)
- [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0)
PR-URL: #13744
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Jul 19, 2017
Big thanks to @addaleax who prepared the vast majority of this release.
Notable changes:
* **Async Hooks**
* Multiple improvements to Promise support in `async_hooks` have been made.
* **Build**
* The compiler version requirement to build Node with GCC has been raised to
GCC 4.9.4.
[[`820b011ed6`](nodejs@820b011ed6)]
[nodejs#13466](nodejs#13466)
* **Cluster**
* Users now have more fine-grained control over the inspector port used by
individual cluster workers. Previously, cluster workers would simply
increment from the master's debug port.
[[`dfc46e262a`](nodejs@dfc46e262a)]
[nodejs#14140](nodejs#14140)
* **DNS**
* The server used for DNS queries can now use a custom port.
[[`ebe7bb29aa`](nodejs@ebe7bb29aa)]
[nodejs#13723](nodejs#13723)
* Support for `dns.resolveAny()` has been added.
[[`6e30e2558e`](nodejs@6e30e2558e)]
[nodejs#13137](nodejs#13137)
* **npm**
* The `npm` CLI has been updated to version 5.3.0. In particular, it now comes
with the `npx` binary, which is also shipped with Node.
[[`dc3f6b9ac1`](nodejs@dc3f6b9ac1)]
[nodejs#14235](nodejs#14235)
* `npm` Changelogs:
- [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4)
- [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0)
- [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0)
- [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0)
PR-URL: nodejs#13744
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
This includes a critical fix to get npx working on Windows
PR-URL: #14235
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 added a commit that referenced this pull request Jul 19, 2017
Big thanks to @addaleax who prepared the vast majority of this release.
Notable changes:
* **Async Hooks**
* Multiple improvements to Promise support in `async_hooks` have been made.
* **Build**
* The compiler version requirement to build Node with GCC has been raised to
GCC 4.9.4.
[[`820b011ed6`](820b011ed6)]
[#13466](#13466)
* **Cluster**
* Users now have more fine-grained control over the inspector port used by
individual cluster workers. Previously, cluster workers would simply
increment from the master's debug port.
[[`dfc46e262a`](dfc46e262a)]
[#14140](#14140)
* **DNS**
* The server used for DNS queries can now use a custom port.
[[`ebe7bb29aa`](ebe7bb29aa)]
[#13723](#13723)
* Support for `dns.resolveAny()` has been added.
[[`6e30e2558e`](6e30e2558e)]
[#13137](#13137)
* **npm**
* The `npm` CLI has been updated to version 5.3.0. In particular, it now comes
with the `npx` binary, which is also shipped with Node.
[[`dc3f6b9ac1`](dc3f6b9ac1)]
[#14235](#14235)
* `npm` Changelogs:
- [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4)
- [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0)
- [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0)
- [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0)
PR-URL: #13744
Fishrock123 added a commit that referenced this pull request Jul 19, 2017
Big thanks to @addaleax who prepared the vast majority of this release.
Notable changes:
* **Async Hooks**
* Multiple improvements to Promise support in `async_hooks` have been made.
* **Build**
* The compiler version requirement to build Node with GCC has been raised to
GCC 4.9.4.
[[`820b011ed6`](820b011ed6)]
[#13466](#13466)
* **Cluster**
* Users now have more fine-grained control over the inspector port used by
individual cluster workers. Previously, cluster workers would simply
increment from the master's debug port.
[[`dfc46e262a`](dfc46e262a)]
[#14140](#14140)
* **DNS**
* The server used for DNS queries can now use a custom port.
[[`ebe7bb29aa`](ebe7bb29aa)]
[#13723](#13723)
* Support for `dns.resolveAny()` has been added.
[[`6e30e2558e`](6e30e2558e)]
[#13137](#13137)
* **npm**
* The `npm` CLI has been updated to version 5.3.0. In particular, it now comes
with the `npx` binary, which is also shipped with Node.
[[`dc3f6b9ac1`](dc3f6b9ac1)]
[#14235](#14235)
* `npm` Changelogs:
- [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4)
- [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0)
- [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0)
- [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0)
PR-URL: #13744
richardlau added a commit to richardlau/node-1 that referenced this pull request Aug 25, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi
package.
Refs: nodejs#14235
BridgeAR pushed a commit that referenced this pull request Aug 29, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi
package.
PR-URL: #15033
Refs: #14235
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi
package.
PR-URL: nodejs/node#15033
Refs: nodejs/node#14235
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi
package.
PR-URL: nodejs/node#15033
Refs: nodejs/node#14235
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi
package.
PR-URL: nodejs#15033
Refs: nodejs#14235
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi
package.
PR-URL: #15033
Refs: #14235
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi
package.
PR-URL: #15033
Refs: #14235
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@okwolfokwolf mentioned this pull request Jan 27, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notable-changePRs with changes that should be highlighted in changelogs.npmIssues and PRs related to the npm client dependency or the npm registry.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@zkat@jasnell@MylesBorins@refack@addaleax@Fishrock123@tniessen@hiroppy@gibfahn@nodejs-github-bot