Uh oh!
There was an error while loading. Please reload this page.
lib: update indentation of ternaries - #14247
Closed
Trott wants to merge 1 commit into
Closed
Conversation
addaleax
commented
Jul 15, 2017
Member
There’s a typo in the commit message ;) |
Member
There was a problem hiding this comment.
This doesn’t need to be a ternary anyway, right? Just result.host && result.host.indexOf('@') > 0 && result.host.split('@') works as well?
MemberAuthor
There was a problem hiding this comment.
Good idea! I don't think there's much of a chance this is being done as a ternary because it's more performant than the alternative approach you're suggesting here. But that's usually behind my reluctance to alter anything other than whitespace in these things. :-D
addaleax
approved these changes
Jul 15, 2017
Trott
commented
Jul 15, 2017
MemberAuthor
Fixed. Thanks! |
Trottforce-pushed
the
indent-ternaries-in-lib
branch
from
July 15, 2017 04:07
379141d to
77b868aComparelpinca
approved these changes
Jul 15, 2017
joyeecheung
approved these changes
Jul 15, 2017
Trottforce-pushed
the
indent-ternaries-in-lib
branch
from
July 15, 2017 06:21
77b868a to
c915e9fCompareIn preparation for stricter indentation linting and to increase code clarity, update indentation for ternaries in lib.
Trott
commented
Jul 15, 2017
MemberAuthor
targos
approved these changes
Jul 15, 2017
gibfahn
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
jasnell
approved these changes
Jul 17, 2017
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jul 18, 2017
In preparation for stricter indentation linting and to increase code clarity, update indentation for ternaries in lib. PR-URL: nodejs#14247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Jul 18, 2017
MemberAuthor
Landed in d14c132 |
Merged
addaleax pushed a commit
that referenced
this pull request
Jul 18, 2017
In preparation for stricter indentation linting and to increase code clarity, update indentation for ternaries in lib. PR-URL: #14247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit
that referenced
this pull request
Jul 19, 2017
In preparation for stricter indentation linting and to increase code clarity, update indentation for ternaries in lib. PR-URL: #14247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
7 tasks
Trott added a commit
to Trott/io.js
that referenced
this pull request
Aug 15, 2017
In preparation for stricter indentation linting and to increase code clarity, update indentation for ternaries in lib. PR-URL: nodejs#14247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Aug 16, 2017
In preparation for stricter indentation linting and to increase code clarity, update indentation for ternaries in lib. Backport-PR-URL: #14835 PR-URL: #14247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Sep 5, 2017
In preparation for stricter indentation linting and to increase code clarity, update indentation for ternaries in lib. Backport-PR-URL: #14835 PR-URL: #14247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for stricter indentation linting and to increase code
clarity, update indentation for ternaries in lib.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib tools