Skip to content

test: improve error message for stream writable change default encoding test - #14264

Closed
fraserxu wants to merge 1 commit into
nodejs:masterfrom
fraserxu:test-stream-writeable-change-default-encoding
Closed

test: improve error message for stream writable change default encoding test#14264
fraserxu wants to merge 1 commit into
nodejs:masterfrom
fraserxu:test-stream-writeable-change-default-encoding

Conversation

@fraserxu

@fraserxufraserxu commented Jul 16, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
@fraserxufraserxu changed the title improve error message for test for stream writable change default enc…test: improve error message for stream writable change default encoding testJul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@TrottTrott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@fraserxu
fraserxuforce-pushed the test-stream-writeable-change-default-encoding branch from 6654c71 to d37a55aCompareJuly 16, 2017 07:23
@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9142/

@TimothyGuTimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

I don't think this needs to wait 72 hours, but a second approval would be good. Anyone?

@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

Landed in 35398af.

Thanks for the contribution! 🎉

@TrottTrott closed this Jul 16, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 16, 2017
@fraserxu@Trott
test: check complete error message
35398af
In test-stream-writable-change-default-encoding, use a regular
expression to match the complete error message.
PR-URL: nodejs#14264
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@fraserxu
fraserxu deleted the test-stream-writeable-change-default-encoding branch July 16, 2017 11:15
@addaleaxaddaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@fraserxu@addaleax
test: check complete error message
c44d899
In test-stream-writable-change-default-encoding, use a regular
expression to match the complete error message.
PR-URL: #14264
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@fraserxu@Fishrock123
test: check complete error message
7eafd96
In test-stream-writable-change-default-encoding, use a regular
expression to match the complete error message.
PR-URL: #14264
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@fraserxu@MylesBorins
test: check complete error message
2014c7f
In test-stream-writable-change-default-encoding, use a regular
expression to match the complete error message.
PR-URL: #14264
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@fraserxu@MylesBorins
test: check complete error message
ed6d4f0
In test-stream-writable-change-default-encoding, use a regular
expression to match the complete error message.
PR-URL: #14264
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@fraserxu@MylesBorins
test: check complete error message
a168361
In test-stream-writable-change-default-encoding, use a regular
expression to match the complete error message.
PR-URL: #14264
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benglbenglbengl approved these changes
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fraserxu@Trott@bengl@MylesBorins@TimothyGu@nodejs-github-bot