Skip to content

test: replace string concatenation in this file with template literals - #14270

Closed
rockcoder23 wants to merge 1 commit into
nodejs:masterfrom
rockcoder23:mynode
Closed

test: replace string concatenation in this file with template literals#14270
rockcoder23 wants to merge 1 commit into
nodejs:masterfrom
rockcoder23:mynode

Conversation

@rockcoder23

@rockcoder23rockcoder23 commented Jul 16, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, require

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@DavidCai1111DavidCai1111 added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
DavidCai1111
DavidCai1111 approved these changes Jul 16, 2017
View reviewed changes

@DavidCai1111DavidCai1111 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/9151/

@TimothyGuTimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@evanlucas

evanlucas commented Jul 16, 2017

Copy link
Copy Markdown
Contributor

Thanks for contributing!

refack
refack reviewed Jul 16, 2017
View reviewed changes
Comment threadtest/parallel/test-require-extensions-same-filename-as-dir-trailing-slash.js
const content = require(common.fixturesDir +
'/json-with-directory-name-module/module-stub/one-trailing-slash/two/three.js');
const filePath = '/json-with-directory-name-module/module-stub/one-trailing-slash/two/three.js';
const content = require(`${common.fixturesDir}${filePath}`);

@refackrefackJul 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Ok.
But it would be much better to use path.join instead, see #14272 (comment)
You could even do it with multiple parts

constfilePath=path.join(common.fixturesDir,'json-with-directory-name-module','module-stub','one-trailing-slash','two','three.js');

@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

Something odd happened with CI so we'll have to re-run it again when the CI server is a little less overwhelmed.

@Trott

Trott commented Jul 17, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9193/

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 26, 2017
@rockcoder23@Trott
test: replace concatenation with template literal
cf25324
PR-URL: nodejs#14270
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott

Trott commented Jul 26, 2017

Copy link
Copy Markdown
Member

Landed in cf25324

Thanks for the contribution! 🎉

@TrottTrott closed this Jul 26, 2017
addaleax pushed a commit that referenced this pull request Jul 27, 2017
@rockcoder23@addaleax
test: replace concatenation with template literal
5057c7a
PR-URL: #14270
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleaxaddaleax mentioned this pull request Aug 2, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@rockcoder23@MylesBorins
test: replace concatenation with template literal
90da435
PR-URL: #14270
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@rockcoder23@MylesBorins
test: replace concatenation with template literal
cdcec0c
PR-URL: #14270
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
@rockcoder23@MylesBorins
test: replace concatenation with template literal
1560e97
PR-URL: #14270
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@rockcoder23@MylesBorins
test: replace concatenation with template literal
6fd3dd2
PR-URL: #14270
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Sep 5, 2017
Closed
Closed
Closed
This was referenced Sep 6, 2017
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
+4 more reviewers
@refackrefackrefack left review comments
@evanlucasevanlucasevanlucas approved these changes
@DavidCai1111DavidCai1111DavidCai1111 approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@rockcoder23@evanlucas@Trott@refack@cjihrig@tniessen@DavidCai1111@gibfahn@MylesBorins@TimothyGu@nodejs-github-bot