Uh oh!
There was an error while loading. Please reload this page.
readline: name some anonymous functions - #14297
Closed
Amunu wants to merge 1 commit into
Closed
Conversation
Trott
previously requested changes
Jul 16, 2017
Trott
left a comment
Member
There was a problem hiding this comment.
These function don't need to be named, but there are anonymous functions used as listeners in some files (such as lib/readline.js) that should probably be named. Do you want to try to name those?
Amunu
commented
Jul 20, 2017
ContributorAuthor
@Trott I've updated the code and PR message. |
Trott
commented
Jul 20, 2017
Member
Great! Thanks! Looks like there's conflicts. Can you rebase against master and resolve them? |
Amunu
commented
Jul 20, 2017
ContributorAuthor
@Trott I've rebased the code. |
cjihrig
approved these changes
Jul 20, 2017
XadillaX
commented
Jul 20, 2017
Contributor
3 tasks
jasnell
approved these changes
Jul 20, 2017
XadillaX
commented
Jul 23, 2017
Contributor
@Trott, I'm not sure that whether CI is OK or not. |
Trott
commented
Jul 23, 2017
Member
@XadillaX CI is fine. The one failure is test-crypto-dh-leak which is a known flaky test. |
XadillaX
commented
Jul 23, 2017
Contributor
Landed in f37e3b1. Thanks. |
XadillaX pushed a commit
that referenced
this pull request
Jul 23, 2017
PR-URL: #14297 Refs: #8913 Refs: #14297 (review) Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
commented
Jul 27, 2017
Member
This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the |
jasnell pushed a commit
that referenced
this pull request
Sep 25, 2017
PR-URL: #14297 Refs: #8913 Refs: #14297 (review) Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #8913
Refs: #14297 (review)
Checklist
make -j4 testAffected core subsystem(s)
readline