Skip to content

docs: add note about fs.rmdir()/fs.rmdirSync() - #14323

Closed
al-k21 wants to merge 1 commit into
nodejs:masterfrom
al-k21:docs
Closed

docs: add note about fs.rmdir()/fs.rmdirSync()#14323
al-k21 wants to merge 1 commit into
nodejs:masterfrom
al-k21:docs

Conversation

@al-k21

@al-k21al-k21 commented Jul 17, 2017•
edited
Loading

Copy link
Copy Markdown

fs.rmdir()/fs.rmdirSync() on the file (not directory) results in different errors on
Windows to everything else

fixes: #8797

Checklist
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jul 17, 2017
vsemozhetbyt
vsemozhetbyt reviewed Jul 17, 2017
View reviewed changes
Comment threaddoc/api/fs.md Outdated

@vsemozhetbytvsemozhetbytJul 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I am not sure, but maybe "on a file"?

gireeshpunathil
gireeshpunathil requested changes Jul 17, 2017
View reviewed changes
Comment threaddoc/api/fs.md Outdated

@gireeshpunathilgireeshpunathilJul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, also it is a good idea to generalize ENOTDIR for UNIX systems, not just Linux.

Trott
Trott reviewed Jul 17, 2017
View reviewed changes
Comment threaddoc/api/fs.md Outdated

@TrottTrottJul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I know you already changed it from Linux to UNIX, but I believe that throughout or docs, we use POSIX (and that includes macOS, or at least it does in our docs).

/cc @nodejs/documentation in case I'm wrong about some aspect of this. :-D

@thefourtheyethefourtheyeJul 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in Sync version as well, right?

@al-k21al-k21 changed the title docs: add note about fs.rmdir()docs: add note about fs.rmdir()/fs.rmdirSync()Jul 17, 2017
gdams
gdams suggested changes Jul 17, 2017
View reviewed changes

@gdamsgdams left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit and then LGTM

Comment threaddoc/api/fs.md Outdated

@gdamsgdamsJul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit not directory => not a directory

Comment threaddoc/api/fs.md Outdated

@gdamsgdamsJul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit not directory => not a directory

gibfahn
gibfahn reviewed Jul 18, 2017
View reviewed changes
Comment threaddoc/api/fs.md Outdated

@gibfahngibfahnJul 18, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENOTDIR error -> an ENOTDIR error (same below)

@Oleksandr-Kushchak-i2
docs: add note about fs.rmdir()
6489a41
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
fixes: nodejs#8797
gdams
gdams approved these changes Jul 18, 2017
View reviewed changes

@gdamsgdams left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Jul 19, 2017
@Oleksandr-Kushchak-i2@jasnell
docs: add note about fs.rmdir()
bd7735e
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell

jasnell commented Jul 19, 2017

Copy link
Copy Markdown
Member

Landed in bd7735e

@jasnelljasnell closed this Jul 19, 2017
@gibfahn

gibfahn commented Jul 20, 2017

Copy link
Copy Markdown
Member

Congrats on becoming a Contributor @al-k21 !

@gdams

gdams commented Jul 22, 2017

Copy link
Copy Markdown
Member

Nice work @al-k21

addaleax pushed a commit that referenced this pull request Jul 22, 2017
@Oleksandr-Kushchak-i2@addaleax
docs: add note about fs.rmdir()
c0cf129
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 24, 2017
@Oleksandr-Kushchak-i2@Fishrock123
docs: add note about fs.rmdir()
f6a0343
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@addaleaxaddaleax mentioned this pull request Jul 24, 2017
Closed
@addaleaxaddaleax mentioned this pull request Aug 2, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Oleksandr-Kushchak-i2@MylesBorins
docs: add note about fs.rmdir()
c6c6ebe
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Oleksandr-Kushchak-i2@MylesBorins
docs: add note about fs.rmdir()
028f650
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
@Oleksandr-Kushchak-i2@MylesBorins
docs: add note about fs.rmdir()
ac245d1
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@Oleksandr-Kushchak-i2@MylesBorins
docs: add note about fs.rmdir()
1d5ba9c
fs.rmdir() on the file (not directory) results in different errors on
Windows to everything else
Fixes: #8797
PR-URL: #14323
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@al-k21
al-k21 deleted the docs branch October 18, 2017 13:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+5 more reviewers
@thefourtheyethefourtheyethefourtheye left review comments
@Fishrock123Fishrock123Fishrock123 approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
@gibfahngibfahngibfahn approved these changes
@gdamsgdamsgdams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.rmdir() on file (not directory) has "ENOTDIR" on Linux/macOS vs "ENOENT" on Windows

14 participants

@al-k21@jasnell@gibfahn@gdams@thefourtheye@Trott@Fishrock123@lpinca@cjihrig@gireeshpunathil@vsemozhetbyt@MylesBorins@nodejs-github-bot@Oleksandr-Kushchak-i2