Skip to content

[v6.x] deps: backport rehash strings after deserialization - #14385

Closed
hashseed wants to merge 6 commits into
nodejs:v6.x-stagingfrom
hashseed:rehash6
Closed

[v6.x] deps: backport rehash strings after deserialization#14385
hashseed wants to merge 6 commits into
nodejs:v6.x-stagingfrom
hashseed:rehash6

Conversation

@hashseed

@hashseedhashseed commented Jul 20, 2017•
edited
Loading

Copy link
Copy Markdown
Member
Original commit messages:
v8/v8@a2ab135
[snapshot] Rehash strings after deserialization.
See https://goo.gl/6aN8xA
Bug: v8:6593
Change-Id: Ic8b0b57195d01d41591397d5d45de3f0f3ebc3d9
Reviewed-on: https://chromium-review.googlesource.com/574527
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46732}
https://github.com/v8/v8/182caaf4a9b94024e47007d426831c024345cb97
Do not track transitions for built-in objects.
Objects created during bootstrapping do not need
a transition tree except for elements kind transitions.
Bug: v8:6596
Change-Id: I237b8b2792f201336e1c9731c815095dd06bc182
Reviewed-on: https://chromium-review.googlesource.com/571750
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46693}
Fixes: https://github.com/nodejs/node/issues/14171
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

sam-githuband others added 5 commits July 18, 2017 15:15
@sam-github@MylesBorins
doc: document and test that methods return this
2fb1381
Also, add tests to ensure they will always return this, and to confirm
they return this when these doc changes are back-ported to earlier
release lines.
PR-URL: nodejs#13553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joaocgreis@MylesBorins
test: mark test-fs-readdir-ucs2 flaky
dce4a75
PR-URL: nodejs#13989
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack@MylesBorins
test: mark test-npm-install flaky on arm
448c8d4
PR-URL: nodejs#14035
Refs: nodejs#14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos@MylesBorins
build: run test-hash-seed at the end of test-v8
3b2c791
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.
Ref: nodejs#14004 (comment)
PR-URL: nodejs#14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@vsemozhetbyt@MylesBorins
cluster, dns, repl, tls, util: fix RegExp nits
ddc8050
* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.
Backport-PR-URL: nodejs#14348
PR-URL: nodejs#13536
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. v6.x v8 engine Issues and PRs related to the V8 dependency. labels Jul 20, 2017
@hashseed
deps: backport rehash strings after deserialization
adcab4d
Original commit messages:
v8/v8@a2ab135
[snapshot] Rehash strings after deserialization.
See https://goo.gl/6aN8xA
Bug: v8:6593
Change-Id: Ic8b0b57195d01d41591397d5d45de3f0f3ebc3d9
Reviewed-on: https://chromium-review.googlesource.com/574527
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#46732}
v8/v8@182caaf
Do not track transitions for built-in objects.
Objects created during bootstrapping do not need
a transition tree except for elements kind transitions.
Bug: v8:6596
Change-Id: I237b8b2792f201336e1c9731c815095dd06bc182
Reviewed-on: https://chromium-review.googlesource.com/571750
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46693}
Fixes: nodejs#14171
PR-URL: nodejs#14385
@hashseed

hashseed commented Jul 20, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@MylesBorins@ofrobots@fhinkel

This back port is a bit more involved, since V8's heap and serializer have changed quite a bit since 5.1.

@hashseedhashseed changed the title deps: backport rehash strings after deserialization.deps: backport rehash strings after deserializationJul 20, 2017
@hashseedhashseed mentioned this pull request Jul 20, 2017
Closed
refack
refack approved these changes Jul 20, 2017
View reviewed changes

@refackrefack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM
configure changes LGTM
Assuming test-v8 and test/pummel/test-hash-seed.js are green

@addaleaxaddaleax changed the title deps: backport rehash strings after deserialization[v6.x] deps: backport rehash strings after deserializationJul 20, 2017
mcollina
mcollina approved these changes Jul 21, 2017
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashseedhashseed closed this Aug 3, 2017
@hashseed
hashseed deleted the rehash6 branch August 3, 2017 05:10
@refack

refack commented Aug 3, 2017

Copy link
Copy Markdown
Contributor

What's the context of closing this?

MylesBorins pushed a commit that referenced this pull request Aug 3, 2017
@hashseed@MylesBorins
deps: backport rehash strings after deserialization
14e4254
Original commit messages:
v8/v8@a2ab135
[snapshot] Rehash strings after deserialization.
See https://goo.gl/6aN8xA
Bug: v8:6593
Change-Id: Ic8b0b57195d01d41591397d5d45de3f0f3ebc3d9
Reviewed-on: https://chromium-review.googlesource.com/574527
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46732}
v8/v8@182caaf
Do not track transitions for built-in objects.
Objects created during bootstrapping do not need
a transition tree except for elements kind transitions.
Bug: v8:6596
Change-Id: I237b8b2792f201336e1c9731c815095dd06bc182
Reviewed-on: https://chromium-review.googlesource.com/571750
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46693}
Fixes: #14171
PR-URL: #14385
@MylesBorins

MylesBorins commented Aug 3, 2017

Copy link
Copy Markdown
Contributor

It looks like the branch was deleted, perhaps accidentally?

I've gone ahead and landed the commit onto v6.x-staging as 14e4254 in case this was accidental (commit would vanish eventually when github clears cache)

This can easily be backed out

@hashseed

hashseed commented Aug 3, 2017

Copy link
Copy Markdown
MemberAuthor

Accident indeed! I was cleaning out old branches...

Anyways, thanks for landing this, Myles!

MylesBorins pushed a commit that referenced this pull request Aug 12, 2017
@hashseed@MylesBorins
deps: backport rehash strings after deserialization
67ce52c
Original commit messages:
v8/v8@a2ab135
[snapshot] Rehash strings after deserialization.
See https://goo.gl/6aN8xA
Bug: v8:6593
Change-Id: Ic8b0b57195d01d41591397d5d45de3f0f3ebc3d9
Reviewed-on: https://chromium-review.googlesource.com/574527
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46732}
v8/v8@182caaf
Do not track transitions for built-in objects.
Objects created during bootstrapping do not need
a transition tree except for elements kind transitions.
Bug: v8:6596
Change-Id: I237b8b2792f201336e1c9731c815095dd06bc182
Reviewed-on: https://chromium-review.googlesource.com/571750
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46693}
Fixes: #14171
PR-URL: #14385
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins added a commit that referenced this pull request Sep 5, 2017
@MylesBorins
2017-09-05, Version 6.11.3 'Boron' (LTS)
dbce2ec
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.
Notable Changes:
* build:
- Codesigning is fixed on macOS (Evan Lucas)
#14179
* deps:
- Snapshots are turned back on!!! (Yang Guo)
#14385
* path:
- win32 volume-relative paths are working again! (Timothy Gu)
#14440
* tools:
- v6.x can now build with ICU 59 (Steven R. Loomis)
#12078
PR-URL: #14852
MylesBorins added a commit that referenced this pull request Sep 5, 2017
@MylesBorins
2017-09-05, Version 6.11.3 'Boron' (LTS)
dc7f03c
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.
Notable Changes:
* build:
- Codesigning is fixed on macOS (Evan Lucas)
#14179
* deps:
- Snapshots are turned back on!!! (Yang Guo)
#14385
* path:
- win32 volume-relative paths are working again! (Timothy Gu)
#14440
* tools:
- v6.x can now build with ICU 59 (Steven R. Loomis)
#12078
PR-URL: #14852
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@MylesBorins@addaleax
2017-09-05, Version 6.11.3 'Boron' (LTS)
83f797b
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.
Notable Changes:
* build:
- Codesigning is fixed on macOS (Evan Lucas)
nodejs#14179
* deps:
- Snapshots are turned back on!!! (Yang Guo)
nodejs#14385
* path:
- win32 volume-relative paths are working again! (Timothy Gu)
nodejs#14440
* tools:
- v6.x can now build with ICU 59 (Steven R. Loomis)
nodejs#12078
PR-URL: nodejs#14852
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
+1 more reviewer
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@hashseed@refack@MylesBorins@mcollina@nodejs-github-bot@sam-github@joaocgreis@targos@vsemozhetbyt