Skip to content

[v8.x backport] assert: make assert.fail doc compliant - #14428

Closed
refack wants to merge 2 commits into
nodejs:v8.x-stagingfrom
refack:v8-port-13862
Closed

[v8.x backport] assert: make assert.fail doc compliant#14428
refack wants to merge 2 commits into
nodejs:v8.x-stagingfrom
refack:v8-port-13862

Conversation

@refack

@refackrefack commented Jul 22, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #13862

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

@refackrefack added assert Issues and PRs related to the assert subsystem. v8.x labels Jul 22, 2017
@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. v8.x labels Jul 22, 2017
@refackrefack mentioned this pull request Jul 22, 2017
Merged
4 tasks
@refack

refack commented Jul 22, 2017

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/9299/

@refack

refack commented Jul 22, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@addaleax

addaleax commented Jul 23, 2017

Copy link
Copy Markdown
Member

This does change an existing test so I’d like to run CITGM first:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/922/

@refack

refack commented Jul 23, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This does change an existing test so I’d like to run CITGM first:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/922/

CitGM is clean.
(also as you probably noticed, test changes are only additions. The PR started as more extensive, but what landed IMHO is semver-patch)fc46363 (#13974) leaked into this.

addaleax
addaleax reviewed Jul 23, 2017
View reviewed changes
Comment threadtest/parallel/test-assert-fail.js Outdated

@addaleaxaddaleaxJul 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack This is not additive.

@refackrefackJul 23, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm.... right.
This is #13974 leaking into my backport. I can take it out.

@addaleaxaddaleaxJul 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do that, the alternative is re-discussing the semverness of #13974

@refack

refack commented Jul 23, 2017

Copy link
Copy Markdown
ContributorAuthor

Reverted fc46363 (#13974) that leaked into this.
But also reopened discussion on semverity of #13974

@refack

refack commented Jul 23, 2017

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/9305/
(Yay for "Rebuild" nodejs/build#672)

@refack

refack commented Jul 23, 2017

Copy link
Copy Markdown
ContributorAuthor

@refack

refack commented Jul 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Rebased: https://ci.nodejs.org/job/node-test-pull-request/9324/

@BridgeAR@refack
doc,assert: document stackStartFunction in fail
94fecdf
PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR@refack
assert: refactor the code
b95ba5b
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments
PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack

refack commented Jul 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Better rebase: https://ci.nodejs.org/job/node-test-commit/11341/

@addaleax

addaleax commented Jul 24, 2017

Copy link
Copy Markdown
Member

LGTM, thank you!

Landed in 78f0c2a, 26785a2 (with the test changes moved back to the commit that they were in originally as chatted about in IRC)

addaleax pushed a commit that referenced this pull request Jul 24, 2017
@BridgeAR@addaleax
doc,assert: document stackStartFunction in fail
78f0c2a
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Backport-PR-URL: #14428
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jul 24, 2017
@BridgeAR@addaleax
assert: refactor the code
26785a2
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Backport-PR-URL: #14428
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
@refack
refack deleted the v8-port-13862 branch September 18, 2017 01:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax left review comments

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@refack@addaleax@nodejs-github-bot@BridgeAR