Uh oh!
There was an error while loading. Please reload this page.
tools: remove legacy indentation linting - #14515
Closed
Trott wants to merge 1 commit into
Closed
Conversation
All linting now uses the current ESLint 4.3.0 indentation linting. Remove legacy indentation rules.
lpinca
approved these changes
Jul 27, 2017
Trott
commented
Jul 27, 2017
MemberAuthor
cjihrig
approved these changes
Jul 27, 2017
claudiorodriguez
approved these changes
Jul 28, 2017
evanlucas
approved these changes
Jul 28, 2017
Trott
commented
Jul 30, 2017
MemberAuthor
Landed in e9b67f7 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2017
All linting now uses the current ESLint 4.3.0 indentation linting. Remove legacy indentation rules. PR-URL: nodejs#14515 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Aug 1, 2017
All linting now uses the current ESLint 4.3.0 indentation linting. Remove legacy indentation rules. PR-URL: #14515 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Merged
7 tasks
Trott added a commit
to Trott/io.js
that referenced
this pull request
Aug 15, 2017
All linting now uses the current ESLint 4.3.0 indentation linting. Remove legacy indentation rules. PR-URL: nodejs#14515 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Aug 16, 2017
All linting now uses the current ESLint 4.3.0 indentation linting. Remove legacy indentation rules. Backport-PR-URL: #14835 PR-URL: #14515 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Sep 5, 2017
All linting now uses the current ESLint 4.3.0 indentation linting. Remove legacy indentation rules. Backport-PR-URL: #14835 PR-URL: #14515 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This was referenced Sep 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All linting now uses the current ESLint 4.3.0 indentation linting.
Remove legacy indentation rules.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools