Skip to content

refactor test/sequential/test-fs-watch.js - #14534

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:watch-scope
Closed

refactor test/sequential/test-fs-watch.js#14534
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:watch-scope

Conversation

@Trott

@TrottTrott commented Jul 29, 2017

Copy link
Copy Markdown
Member
  • add block scoping
  • rename block-scoped identifiers (e.g., filenameTwo -> filename)
  • use common.mustCall() instead of exit handler
  • order modules per test writing guide
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

@TrottTrott added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels Jul 29, 2017
@Trott

Trott commented Jul 29, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/9399/

@Trott

Trott commented Jul 30, 2017

Copy link
Copy Markdown
MemberAuthor

@nodejs/testing

@refackrefack mentioned this pull request Jul 30, 2017
Closed
3 tasks
cjihrig
cjihrig approved these changes Jul 30, 2017
View reviewed changes
Comment threadtest/sequential/test-fs-watch.js Outdated

@cjihrigcjihrigJul 30, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, can we have something nicer than assert(0)

@TrottTrottJul 30, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to common.mustNotCall(). Thanks.

@Trott
test: refactor test/sequential/test-fs-watch.js
a2bacbe
* add block scoping
* rename block-scoped identifiers (e.g., filenameTwo -> filename)
* use common.mustCall() instead of exit handler
* use common.mustNotCall() as appropriate
* order modules per test writing guide
@Trott

Trott commented Jul 30, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/9410/

@Trott

Trott commented Aug 1, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 8c2cac6

@TrottTrott closed this Aug 1, 2017
Trott added a commit to Trott/io.js that referenced this pull request Aug 1, 2017
@Trott
test: refactor test/sequential/test-fs-watch.js
8c2cac6
* add block scoping
* rename block-scoped identifiers (e.g., filenameTwo -> filename)
* use common.mustCall() instead of exit handler
* use common.mustNotCall() as appropriate
* order modules per test writing guide
PR-URL: nodejs#14534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax

addaleax commented Aug 1, 2017

Copy link
Copy Markdown
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it just add the dont-land-on label, for a single test that should be fine.

Trott added a commit to Trott/io.js that referenced this pull request Aug 1, 2017
@Trott
test: refactor test/sequential/test-fs-watch.js
368d6bb
* add block scoping
* rename block-scoped identifiers (e.g., filenameTwo -> filename)
* use common.mustCall() instead of exit handler
* use common.mustNotCall() as appropriate
* order modules per test writing guide
PR-URL: nodejs#14534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

Trott commented Aug 1, 2017

Copy link
Copy Markdown
MemberAuthor

I think this (and I'd guess a lot of other things) will land cleanly if #14162 is backported first. Still, I want this to land so I'm going to go backport it right now...

@TrottTrott mentioned this pull request Aug 1, 2017
Closed
4 tasks
@Trott

Trott commented Aug 1, 2017

Copy link
Copy Markdown
MemberAuthor

Backported in #14575

addaleax pushed a commit that referenced this pull request Aug 1, 2017
@Trott@addaleax
test: refactor test/sequential/test-fs-watch.js
ce9e3cf
* add block scoping
* rename block-scoped identifiers (e.g., filenameTwo -> filename)
* use common.mustCall() instead of exit handler
* use common.mustNotCall() as appropriate
* order modules per test writing guide
Backport-PR-URL: #14575
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #14534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleaxaddaleax mentioned this pull request Aug 2, 2017
Merged
@MylesBorins

MylesBorins commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@Trott
Trott deleted the watch-scope branch January 13, 2022 22:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

fsIssues and PRs related to the fs subsystem / file system.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@addaleax@MylesBorins@cjihrig