Uh oh!
There was an error while loading. Please reload this page.
tools: replace assert-throw-arguments custom lint - #14547
Closed
Trott wants to merge 1 commit into
Closed
Conversation
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries.
cjihrig
approved these changes
Jul 31, 2017
lpinca
approved these changes
Jul 31, 2017
Trott
commented
Jul 31, 2017
MemberAuthor
tniessen
approved these changes
Jul 31, 2017
jasnell
approved these changes
Jul 31, 2017
Trott
commented
Aug 2, 2017
MemberAuthor
Landed in e506bcd |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2017
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries. PR-URL: nodejs#14547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Aug 7, 2017
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries. PR-URL: #14547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Aug 16, 2017
Contributor
Should this be backported to |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Sep 7, 2017
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries. PR-URL: nodejs#14547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
Trott
commented
Sep 7, 2017
MemberAuthor
@MylesBorins Backport in #15253 |
MylesBorins pushed a commit
that referenced
this pull request
Sep 19, 2017
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries. Backport-PR-URL: #15253 PR-URL: #14547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)