build,win: fix python detection script to handle spaces in path

[jasongin]

vcbuild.bat silently failed for me. I found the problem was the new find_python.cmd script failed to invoke python.exe because mine was installed at "C:\Program Files\Python27". Adding quotes in a few places fixed it.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

build, win

[jasongin]

CI: https://ci.nodejs.org/job/node-test-pull-request/9417

[refack]

vcbuild.bat silently failed for me.

Can you think of a good point for it to make noise? That is echo an error?

[jasongin]

Can you think of a good point for it to make noise? That is echo an error?

Well, there is already this code in vcbuild.bat:

call tools\msvs\find_python.cmd
iferrorlevel1echo Could not find python2 &goto :exit

And then I would have expected that to be triggered by the second line here in find_python.cmd:

%p%python.exe -V 2>&1 |findstr /R "^Python.2.*">NULIFERRORLEVEL1EXIT /B %ERRORLEVEL%

However, when there is a space in the path, the script just dies at the findstr call there. I don't understand it, and I can't figure out any way to actually detect that error.

[refack]

However, when there is a space in the path, the script just dies at the findstr call there. I don't understand it, and I can't figure out any way to actually detect that error.

Well... cmd.exe what can you do 🤷‍♂️ ... (I probably should have written it in PS)

[jasongin]

Landed in cee8d6d