Skip to content

[8.x] Backport http test improvements - #14583

Closed
jasnell wants to merge 1 commit into
nodejs:v8.x-stagingfrom
jasnell:8x-backport-14315
Closed

[8.x] Backport http test improvements#14583
jasnell wants to merge 1 commit into
nodejs:v8.x-stagingfrom
jasnell:8x-backport-14315

Conversation

@jasnell

@jasnelljasnell commented Aug 1, 2017

Copy link
Copy Markdown
Member

Backport of #14315 to 8.x-staging

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@jasnell
test: improvements to various http tests
4cddc05
* Add common/countdown utility
* Numerous improvements to http tests
PR-URL: nodejs#14315
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Aug 1, 2017
@jasnell
jasnell requested a review from addaleaxAugust 1, 2017 22:55
addaleax
addaleax approved these changes Aug 1, 2017
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

addaleax pushed a commit that referenced this pull request Aug 1, 2017
@jasnell@addaleax
test: improvements to various http tests
b1fef05
* Add common/countdown utility
* Numerous improvements to http tests
Backport-PR-URL: #14583
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #14315
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@addaleax

addaleax commented Aug 1, 2017

Copy link
Copy Markdown
Member

Landed in b1fef05

@addaleaxaddaleax closed this Aug 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasnell@addaleax@nodejs-github-bot